Subzero. Allocate global initializers from a dedicated arena.

Subzero. Allocate global initializers from a dedicated arena.

This allows Subzero to release the global initializers once they've been
lowered.

This CL also modifies the global initializer types to ensure they are
trivially destructible -- therefore not requiring destructors to run.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4360
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a78e4baab1557beccdb7604175dcea97ef1afe06

[John, 2016-03-14 21:01:46]

jpp@chromium.org changed reviewers:
+ eholk@chromium.org, kschimpf@google.com, sehr@chromium.org,
stichnot@chromium.org

[Jim Stichnoth, 2016-03-14 21:40:41]

Description was changed from

==========
Subzero. Allocate global initializers from a dedicated arena.

This allows Subzero to release the global initializers once they've been
lowered.

This CL also modifies the global initializer types to ensure they are
trivially destructible -- therefore not requiring destructors to run.

BUG=
==========

to

==========
Subzero. Allocate global initializers from a dedicated arena.

This allows Subzero to release the global initializers once they've been
lowered.

This CL also modifies the global initializer types to ensure they are
trivially destructible -- therefore not requiring destructors to run.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4360
==========

[Jim Stichnoth, 2016-03-14 22:21:32]

lgtm

https://codereview.chromium.org/1776473007/diff/100001/src/IceCompiler.cpp
File src/IceCompiler.cpp (right):

https://codereview.chromium.org/1776473007/diff/100001/src/IceCompiler.cpp#ne...
src/IceCompiler.cpp:97: // ice.
"Ice" instead of "ice"?  Also, I think we exclusively use "LLVM" instead of
"llvm" in that context.

https://codereview.chromium.org/1776473007/diff/100001/src/IceDefs.h
File src/IceDefs.h (right):

https://codereview.chromium.org/1776473007/diff/100001/src/IceDefs.h#newcode148
src/IceDefs.h:148: /// VariableDeclarationList is a container for holding
VariableDeclarations --
Can this go somewhere besides IceDefs.h?

https://codereview.chromium.org/1776473007/diff/100001/src/IceDefs.h#newcode222
src/IceDefs.h:222: /// Vector<VariableDeclaration *> interface.
I assume this comment means either "VariableDeclarationArray interface", or
"Adapt the relevant parts of the std::vector<VariableDeclaration *> interface" ?
 Otherwise it kind of looks like a typo.

[John, 2016-03-15 15:07:18]

ptal

https://codereview.chromium.org/1776473007/diff/100001/src/IceCompiler.cpp
File src/IceCompiler.cpp (right):

https://codereview.chromium.org/1776473007/diff/100001/src/IceCompiler.cpp#ne...
src/IceCompiler.cpp:97: // ice.
On 2016/03/14 22:21:31, stichnot wrote:
> "Ice" instead of "ice"?  Also, I think we exclusively use "LLVM" instead of
> "llvm" in that context.

Done.

https://codereview.chromium.org/1776473007/diff/100001/src/IceDefs.h
File src/IceDefs.h (right):

https://codereview.chromium.org/1776473007/diff/100001/src/IceDefs.h#newcode148
src/IceDefs.h:148: /// VariableDeclarationList is a container for holding
VariableDeclarations --
On 2016/03/14 22:21:31, stichnot wrote:
> Can this go somewhere besides IceDefs.h?

It **should**, but because IceDefs moving it to a proper place (i.e.,
IceGlobalInits.h) requires moar changes.

I will leave this as is, in the hopes that the monstrosity IceDefs is becoming
will soon encourage/demand refactoring it (i.e., getting rid of it completely.)

https://codereview.chromium.org/1776473007/diff/100001/src/IceDefs.h#newcode222
src/IceDefs.h:222: /// Vector<VariableDeclaration *> interface.
On 2016/03/14 22:21:31, stichnot wrote:
> I assume this comment means either "VariableDeclarationArray interface", or
> "Adapt the relevant parts of the std::vector<VariableDeclaration *> interface"
?
>  Otherwise it kind of looks like a typo.

Done.

[Jim Stichnoth, 2016-03-15 15:48:29]

still lgtm

https://codereview.chromium.org/1776473007/diff/100001/src/IceDefs.h
File src/IceDefs.h (right):

https://codereview.chromium.org/1776473007/diff/100001/src/IceDefs.h#newcode148
src/IceDefs.h:148: /// VariableDeclarationList is a container for holding
VariableDeclarations --
On 2016/03/15 15:07:18, John wrote:
> On 2016/03/14 22:21:31, stichnot wrote:
> > Can this go somewhere besides IceDefs.h?
> 
> It **should**, but because IceDefs moving it to a proper place (i.e.,
> IceGlobalInits.h) requires moar changes.
> 
> I will leave this as is, in the hopes that the monstrosity IceDefs is becoming
> will soon encourage/demand refactoring it (i.e., getting rid of it
completely.)

Ick ick ick, but whatevs. :)

[John, 2016-03-15 16:28:07]

Description was changed from

==========
Subzero. Allocate global initializers from a dedicated arena.

This allows Subzero to release the global initializers once they've been
lowered.

This CL also modifies the global initializer types to ensure they are
trivially destructible -- therefore not requiring destructors to run.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4360
==========

to

==========
Subzero. Allocate global initializers from a dedicated arena.

This allows Subzero to release the global initializers once they've been
lowered.

This CL also modifies the global initializer types to ensure they are
trivially destructible -- therefore not requiring destructors to run.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4360
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[John, 2016-03-15 16:28:08]

Committed patchset #8 (id:140001) manually as
a78e4baab1557beccdb7604175dcea97ef1afe06 (presubmit successful).