Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1776473006: dart2js cps: Do field calls directly instead going through the adapter. (Closed)

Created:
4 years, 9 months ago by asgerf
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Do field calls directly instead going through the adapter. E.g. obj.foo$1(x) becomes obj.foo.call$1(x). BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/40f6c6934c0bb43ce0577f45e284fcbadbaaa9c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
I also tried doing this during the inlining pass the same way adapters for default ...
4 years, 9 months ago (2016-03-09 14:20:19 UTC) #2
Kevin Millikin (Google)
LGTM
4 years, 9 months ago (2016-03-09 14:50:27 UTC) #3
asgerf
4 years, 9 months ago (2016-03-09 14:59:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
40f6c6934c0bb43ce0577f45e284fcbadbaaa9c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698