Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1776423002: Closure: update doc to advocate for v2 and deprecate v1 (Closed)

Created:
4 years, 9 months ago by Dan Beam
Modified:
4 years, 9 months ago
Reviewers:
dpapad
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Closure: update doc to advocate for v2 and deprecate v1 R=dpapad@chromium.org BUG=585553 NOTRY=true Committed: https://crrev.com/43f31ddba9e5c8e46002ce73014cd5a3e562607c Cr-Commit-Position: refs/heads/master@{#380236}

Patch Set 1 #

Patch Set 2 : spelling nit #

Total comments: 2

Patch Set 3 : -j4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -8 lines) Patch
M docs/closure_compilation.md View 1 2 1 chunk +30 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
Dan Beam
4 years, 9 months ago (2016-03-09 20:08:58 UTC) #3
dpapad
LGTM https://codereview.chromium.org/1776423002/diff/20001/docs/closure_compilation.md File docs/closure_compilation.md (right): https://codereview.chromium.org/1776423002/diff/20001/docs/closure_compilation.md#newcode41 docs/closure_compilation.md:41: ninja -C out/Default Nit(optional): You might want to ...
4 years, 9 months ago (2016-03-09 20:19:22 UTC) #4
Dan Beam
https://codereview.chromium.org/1776423002/diff/20001/docs/closure_compilation.md File docs/closure_compilation.md (right): https://codereview.chromium.org/1776423002/diff/20001/docs/closure_compilation.md#newcode41 docs/closure_compilation.md:41: ninja -C out/Default On 2016/03/09 20:19:22, dpapad wrote: > ...
4 years, 9 months ago (2016-03-09 21:53:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776423002/40001
4 years, 9 months ago (2016-03-09 21:54:50 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-09 22:06:10 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 22:47:43 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/43f31ddba9e5c8e46002ce73014cd5a3e562607c
Cr-Commit-Position: refs/heads/master@{#380236}

Powered by Google App Engine
This is Rietveld 408576698