Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Unified Diff: chrome/browser/ui/webui/settings/md_settings_ui.cc

Issue 1776393003: MD Settings: avoid double pref observation on Startup Pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: doc comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/md_settings_ui.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_ui.cc b/chrome/browser/ui/webui/settings/md_settings_ui.cc
index 2743fcbb8ae3b9947085e0a26bb9683ba75eadac..6ee2da9b86dd1e77ba3d40d9b7a427963569f728 100644
--- a/chrome/browser/ui/webui/settings/md_settings_ui.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_ui.cc
@@ -125,12 +125,16 @@ MdSettingsUI::MdSettingsUI(content::WebUI* web_ui)
MdSettingsUI::~MdSettingsUI() {
}
-void MdSettingsUI::AddSettingsPageUIHandler(
- content::WebUIMessageHandler* handler_raw) {
- scoped_ptr<content::WebUIMessageHandler> handler(handler_raw);
- DCHECK(handler.get());
+void MdSettingsUI::RenderViewReused(
+ content::RenderViewHost* /*render_view_host*/) {
+ for (SettingsPageUIHandler* handler : handlers_)
+ handler->RenderViewReused();
+}
- web_ui()->AddMessageHandler(handler.release());
+void MdSettingsUI::AddSettingsPageUIHandler(SettingsPageUIHandler* handler) {
+ DCHECK(handler);
+ handlers_.insert(handler);
+ web_ui()->AddMessageHandler(handler); // |handler| is owned by |web_ui()|.
}
void MdSettingsUI::DidStartProvisionalLoadForFrame(
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_ui.h ('k') | chrome/browser/ui/webui/settings/people_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698