Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1776383002: Use correct gradient calculation for rotated distance fields. (Closed)

Created:
4 years, 9 months ago by jvanverth1
Modified:
4 years, 9 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use correct gradient calculation for rotated distance fields. For all uniform scaled matrices, we were using the y coordinate of the y-direction gradient of the v texel space coordinate to scale the distance values. The problem is, if you rotate by 90 degrees this value becomes 0. The correct answer is to take the length of the y-direction gradient. BUG=skia:4864 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1776383002 Committed: https://skia.googlesource.com/skia/+/cf371bb41b4a0591347a076ce7d83336d4bbc6fb

Patch Set 1 #

Patch Set 2 : Fix android error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -29 lines) Patch
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/batches/GrAtlasTextBatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 1 9 chunks +72 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jvanverth1
I've separated the pure uniform scale case from the uniform scale + rotation case, as ...
4 years, 9 months ago (2016-03-09 19:40:09 UTC) #3
bsalomon
lgtm
4 years, 9 months ago (2016-03-10 15:38:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776383002/1
4 years, 9 months ago (2016-03-10 15:46:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/7003)
4 years, 9 months ago (2016-03-10 15:47:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776383002/20001
4 years, 9 months ago (2016-03-10 18:55:19 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 19:10:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/cf371bb41b4a0591347a076ce7d83336d4bbc6fb

Powered by Google App Engine
This is Rietveld 408576698