chromecast/media/cma/pipeline/video_pipeline_impl.h - Issue 1776353006: [Chromecast] Add metrics for logging platform A/V bitrate estimates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/media/cma/pipeline/video_pipeline_impl.h

Issue 1776353006: [Chromecast] Add metrics for logging platform A/V bitrate estimates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix formatting issue Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/media/cma/pipeline/audio_pipeline_impl.cc ('K') | « chromecast/media/cma/pipeline/audio_pipeline_impl.cc ('k') | chromecast/media/cma/pipeline/video_pipeline_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/media/cma/pipeline/video_pipeline_impl.h

diff --git a/chromecast/media/cma/pipeline/video_pipeline_impl.h b/chromecast/media/cma/pipeline/video_pipeline_impl.h

index 09b944824ecf8e962a18bd8b41a021f4d8e1106d..29231a51233f27c415daab5741d6cfb58ede7593 100644

--- a/chromecast/media/cma/pipeline/video_pipeline_impl.h

+++ b/chromecast/media/cma/pipeline/video_pipeline_impl.h

@@ -47,6 +47,9 @@ class VideoPipelineImpl : public AvPipelineImpl {

MediaPipelineBackend::VideoDecoder* const video_decoder_;

const VideoPipelineClient::NaturalSizeChangedCB natural_size_changed_cb_;

+ base::Time last_sample_time_;

+ base::TimeDelta elapsed_time_delta_;

+ int video_bytes_for_bitrate_estimation_;

halliwell 2016/03/10 17:57:54 I was about to leave 'ditto' comments on the video

ejason 2016/03/11 00:24:45 Done. I refactored the code so that this calculati

DISALLOW_COPY_AND_ASSIGN(VideoPipelineImpl);

};