[Chromecast] Add metrics for logging platform A/V bitrate estimates.

chromecast/media/cma/pipeline/media_pipeline_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/media/cma/pipeline/media_pipeline_impl.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/callback_helpers.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/single_thread_task_runner.h"
 #include "base/thread_task_runner_handle.h"
-#include "base/time/time.h"
 #include "chromecast/base/metrics/cast_metrics_helper.h"
 #include "chromecast/media/cdm/browser_cdm_cast.h"
 #include "chromecast/media/cma/base/buffering_controller.h"
 #include "chromecast/media/cma/base/buffering_state.h"
 #include "chromecast/media/cma/base/cma_logging.h"
 #include "chromecast/media/cma/base/coded_frame_provider.h"
 #include "chromecast/media/cma/pipeline/audio_decoder_software_wrapper.h"
 #include "chromecast/media/cma/pipeline/audio_pipeline_impl.h"
 #include "chromecast/media/cma/pipeline/video_pipeline_impl.h"
 #include "chromecast/public/media/media_pipeline_backend.h"
@@ skipping 17 matching lines @@
     base::TimeDelta::FromMilliseconds(300));
 
 // Interval between two updates of the media time.
 const base::TimeDelta kTimeUpdateInterval(
     base::TimeDelta::FromMilliseconds(250));
 
 // Interval between two updates of the statistics is equal to:
 // kTimeUpdateInterval * kStatisticsUpdatePeriod.
 const int kStatisticsUpdatePeriod = 4;
 
+void LogEstimatedBitrate(int decoded_bytes,
+                         base::TimeDelta elapsed_time,
+                         const char* tag,
+                         const char* metric) {
+  int estimated_bitrate_in_kbps =
+      8 * decoded_bytes / elapsed_time.InMilliseconds();
+
+  if (estimated_bitrate_in_kbps <= 0)
+    return;
+
+  CMALOG(kLogControl) << "Estimated " << tag << " bitrate is "
+                      << estimated_bitrate_in_kbps << " kbps";
+  metrics::CastMetricsHelper* metrics_helper =
+      metrics::CastMetricsHelper::GetInstance();
+  metrics_helper->RecordSimpleActionWithValue(metric,
+                                              estimated_bitrate_in_kbps);
+}
+
 }  // namespace
 
 struct MediaPipelineImpl::FlushTask {
   bool audio_flushed;
   bool video_flushed;
   base::Closure done_cb;
 };
 
 MediaPipelineImpl::MediaPipelineImpl()
     : cdm_(nullptr),
       backend_state_(BACKEND_STATE_UNINITIALIZED),
       playback_rate_(1.0f),
       audio_decoder_(nullptr),
       video_decoder_(nullptr),
       pending_time_update_task_(false),
       statistics_rolling_counter_(0),
+      audio_bytes_for_bitrate_estimation_(0),
+      video_bytes_for_bitrate_estimation_(0),
       weak_factory_(this) {
   CMALOG(kLogControl) << __FUNCTION__;
   weak_this_ = weak_factory_.GetWeakPtr();
   thread_checker_.DetachFromThread();
 }
 
 MediaPipelineImpl::~MediaPipelineImpl() {
   CMALOG(kLogControl) << __FUNCTION__;
   DCHECK(thread_checker_.CalledOnValidThread());
 
@@ skipping 116 matching lines @@
     }
     backend_state_ = BACKEND_STATE_INITIALIZED;
   }
 
   // Start the backend.
   if (!media_pipeline_backend_->Start(time.InMicroseconds())) {
     OnError(::media::PIPELINE_ERROR_ABORT);
     return;
   }
   backend_state_ = BACKEND_STATE_PLAYING;
+  ResetBitrateState();
   metrics::CastMetricsHelper::GetInstance()->RecordSimpleAction(
       "Cast.Platform.Playing");
 
   // Enable time updates.
   statistics_rolling_counter_ = 0;
   if (!pending_time_update_task_) {
     pending_time_update_task_ = true;
     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE, base::Bind(&MediaPipelineImpl::UpdateMediaTime, weak_this_));
   }
@@ skipping 94 matching lines @@
 
   playback_rate_ = rate;
   if (buffering_controller_ && buffering_controller_->IsBuffering())
     return;
 
   if (rate != 0.0f) {
     media_pipeline_backend_->SetPlaybackRate(rate);
     if (backend_state_ == BACKEND_STATE_PAUSED) {
       media_pipeline_backend_->Resume();
       backend_state_ = BACKEND_STATE_PLAYING;
+      ResetBitrateState();
       metrics::CastMetricsHelper::GetInstance()->RecordSimpleAction(
           "Cast.Platform.Playing");
     }
   } else if (backend_state_ == BACKEND_STATE_PLAYING) {
     media_pipeline_backend_->Pause();
     backend_state_ = BACKEND_STATE_PAUSED;
     metrics::CastMetricsHelper::GetInstance()->RecordSimpleAction(
         "Cast.Platform.Pause");
   }
 }
@@ skipping 77 matching lines @@
   pending_time_update_task_ = false;
   if ((backend_state_ != BACKEND_STATE_PLAYING) &&
       (backend_state_ != BACKEND_STATE_PAUSED))
     return;
 
   if (statistics_rolling_counter_ == 0) {
     if (audio_pipeline_)
       audio_pipeline_->UpdateStatistics();
     if (video_pipeline_)
       video_pipeline_->UpdateStatistics();
+
+    if (backend_state_ == BACKEND_STATE_PLAYING) {
+      base::TimeTicks current_time = base::TimeTicks::Now();
+      audio_bytes_for_bitrate_estimation_ +=
+          audio_pipeline_->bytes_decoded_since_last_update();

[halliwell, 2016/03/11 21:22:36]

It's possible to not have an audio pipeline, so need to guard with if
(audio_pipeline_)

[ejason, 2016/03/11 22:14:45]

Good catch, oversight on my part. Done.

+      video_bytes_for_bitrate_estimation_ +=
+          video_pipeline_->bytes_decoded_since_last_update();

[halliwell, 2016/03/11 21:22:36]

Ditto.

[ejason, 2016/03/11 22:14:46]

Done.

+      elapsed_time_delta_ += current_time - last_sample_time_;
+      if (elapsed_time_delta_.InMilliseconds() > 5000) {
+        LogEstimatedBitrate(audio_bytes_for_bitrate_estimation_,
+                            elapsed_time_delta_, "audio",
+                            "Cast.Platform.AudioBitrate");
+        LogEstimatedBitrate(video_bytes_for_bitrate_estimation_,
+                            elapsed_time_delta_, "video",
+                            "Cast.Platform.VideoBitrate");
+        ResetBitrateState();
+      }
+      last_sample_time_ = current_time;
+    }
   }
+
   statistics_rolling_counter_ =
       (statistics_rolling_counter_ + 1) % kStatisticsUpdatePeriod;
 
   base::TimeDelta media_time = base::TimeDelta::FromMicroseconds(
       media_pipeline_backend_->GetCurrentPts());
   if (media_time == ::media::kNoTimestamp()) {
     pending_time_update_task_ = true;
     base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
         FROM_HERE, base::Bind(&MediaPipelineImpl::UpdateMediaTime, weak_this_),
         kTimeUpdateInterval);
@@ skipping 32 matching lines @@
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK_NE(error, ::media::PIPELINE_OK) << "PIPELINE_OK is not an error!";
 
   metrics::CastMetricsHelper::GetInstance()->RecordSimpleAction(
       "Cast.Platform.Error");
 
   if (!client_.error_cb.is_null())
     client_.error_cb.Run(error);
 }
 
+void MediaPipelineImpl::ResetBitrateState() {
+  elapsed_time_delta_ = base::TimeDelta::FromSeconds(0);
+  audio_bytes_for_bitrate_estimation_ = 0;
+  video_bytes_for_bitrate_estimation_ = 0;
+  last_sample_time_ = base::TimeTicks::Now();
+}
+
 }  // namespace media
 }  // namespace chromecast