Better error message for assignment to final local variables

runtime/vm/parser.cc

Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc	(revision 32974)
+++ runtime/vm/parser.cc	(working copy)
@@ -7872,13 +7872,15 @@
     if (name.IsNull()) {
       ErrorMsg(left_pos, "expression is not assignable");
     }
-    result = ThrowNoSuchMethodError(original->token_pos(),
-                                    *target_cls,
-                                    name,
-                                    NULL,  // No arguments.
-                                    InvocationMirror::kStatic,
-                                    InvocationMirror::kSetter,
-                                    NULL);  // No existing function.
+    result = ThrowNoSuchMethodError(
+                 original->token_pos(),

[Ivan Posva, 2014/02/25 07:10:07]

Bad indentation.

[hausner, 2014/02/25 18:47:05]

Moved parameters to the left. I find it unreadable to cram the conditional
expressions over 3 lines if the parameters are lined up with the opening paren
of the function call.

+                 *target_cls,
+                 name,
+                 NULL,  // No arguments.
+                 InvocationMirror::kStatic,
+                 original->IsLoadLocalNode() ?
+                     InvocationMirror::kLocalVar : InvocationMirror::kSetter,
+                 NULL);  // No existing function.
   } else if (result->IsStoreIndexedNode() ||
              result->IsInstanceSetterNode() ||
              result->IsStaticSetterNode() ||