Add bitmaps and skp output to Skia port

samples/pdfium_test.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
 #include <list>
@@ skipping 13 matching lines @@
 
 #ifdef PDF_ENABLE_V8
 #include "v8/include/libplatform/libplatform.h"
 #include "v8/include/v8.h"
 #endif  // PDF_ENABLE_V8
 
 #ifdef _WIN32
 #define snprintf _snprintf
 #endif
 
+#ifdef _SKIA_SUPPORT_

[Tom Sepez, 2016/03/10 22:55:32]

Technicaly, identifiers beginning with an underscore and a CAP letter are
reserved for the implementation.  Is this a new #define, or something
pre-exisiting?

[caryclark, 2016/03/11 12:40:34]

Changed the define so that it is clear what is specific to the app and what is
is specific to the impementation (done)

+#include "third_party/skia/include/core/SkPictureRecorder.h"
+#include "third_party/skia/include/core/SkStream.h"
+#endif
+
 enum OutputFormat {
   OUTPUT_NONE,
   OUTPUT_PPM,
   OUTPUT_PNG,
 #ifdef _WIN32
   OUTPUT_BMP,
   OUTPUT_EMF,
 #endif
+#ifdef _SKIA_SUPPORT_
+  OUTPUT_SKP,
+#endif
 };
 
 struct Options {
   Options() : show_config(false), output_format(OUTPUT_NONE) {}
 
   bool show_config;
   OutputFormat output_format;
   std::string scale_factor_as_string;
   std::string exe_path;
   std::string bin_directory;
@@ skipping 57 matching lines @@
           buffer, width, height, stride, false, &png_encoding)) {
     fprintf(stderr, "Failed to convert bitmap to PNG\n");
     return;
   }
 
   char filename[256];
   int chars_formatted = snprintf(
       filename, sizeof(filename), "%s.%d.png", pdf_name, num);
   if (chars_formatted < 0 ||
       static_cast<size_t>(chars_formatted) >= sizeof(filename)) {
-    fprintf(stderr, "Filname %s is too long\n", filename);
+    fprintf(stderr, "Filename %s is too long\n", filename);
     return;
   }
 
   FILE* fp = fopen(filename, "wb");
   if (!fp) {
     fprintf(stderr, "Failed to open %s for output\n", filename);
     return;
   }
 
   size_t bytes_written = fwrite(
@@ skipping 58 matching lines @@
   // If a PS_NULL pen is used, the dimensions of the rectangle are 1 pixel less.
   Rectangle(dc, 0, 0, width + 1, height + 1);
 
   FPDF_RenderPage(dc, page, 0, 0, width, height, 0,
                   FPDF_ANNOT | FPDF_PRINTING | FPDF_NO_CATCH);
 
   DeleteEnhMetaFile(CloseEnhMetaFile(dc));
 }
 #endif
 
+#ifdef _SKIA_SUPPORT_
+void WriteSkp(const char* pdf_name, int num, const void* recorder) {
+  char filename[256];
+  int chars_formatted =
+      snprintf(filename, sizeof(filename), "%s.%d.skp", pdf_name, num);
+
+  if (chars_formatted < 0 ||
+      static_cast<size_t>(chars_formatted) >= sizeof(filename)) {
+    fprintf(stderr, "Filename %s is too long\n", filename);
+    return;
+  }
+
+  SkPictureRecorder* r = (SkPictureRecorder*)recorder;
+  SkPicture* picture = r->endRecordingAsPicture();
+  SkFILEWStream wStream(filename);
+  picture->serialize(&wStream);
+}
+#endif
+
 // These example JS platform callback handlers are entirely optional,
 // and exist here to show the flow of information from a document back
 // to the embedder.
 int ExampleAppAlert(IPDF_JSPLATFORM*,
                     FPDF_WIDESTRING msg,
                     FPDF_WIDESTRING title,
                     int nType,
                     int nIcon) {
   printf("%ls", GetPlatformWString(title).c_str());
   if (nIcon || nType)
@@ skipping 104 matching lines @@
         fprintf(stderr, "Duplicate or conflicting --ppm argument\n");
         return false;
       }
       options->output_format = OUTPUT_PPM;
     } else if (cur_arg == "--png") {
       if (options->output_format != OUTPUT_NONE) {
         fprintf(stderr, "Duplicate or conflicting --png argument\n");
         return false;
       }
       options->output_format = OUTPUT_PNG;
+#ifdef _SKIA_SUPPORT_
+    } else if (cur_arg == "--skp") {
+      if (options->output_format != OUTPUT_NONE) {
+        fprintf(stderr, "Duplicate or conflicting --skp argument\n");
+        return false;
+      }
+      options->output_format = OUTPUT_SKP;
+#endif
     } else if (cur_arg.size() > 11 &&
                cur_arg.compare(0, 11, "--font-dir=") == 0) {
       if (!options->font_directory.empty()) {
         fprintf(stderr, "Duplicate --font-dir argument\n");
         return false;
       }
       options->font_directory = cur_arg.substr(11);
 #ifdef _WIN32
     } else if (cur_arg == "--emf") {
       if (options->output_format != OUTPUT_NONE) {
@@ skipping 92 matching lines @@
       break;
 #endif
     case OUTPUT_PNG:
       WritePng(name.c_str(), page_index, buffer, stride, width, height);
       break;
 
     case OUTPUT_PPM:
       WritePpm(name.c_str(), page_index, buffer, stride, width, height);
       break;
 
+#ifdef _SKIA_SUPPORT_
+    case OUTPUT_SKP: {
+      std::unique_ptr<SkPictureRecorder> recorder(
+          (SkPictureRecorder*)FPDF_RenderPageSkp(page, width, height));
+      FPDF_FFLRecord(form, recorder.get(), page, 0, 0, width, height, 0, 0);
+      WriteSkp(name.c_str(), page_index, recorder.get());
+    } break;
+#endif
     default:
       break;
   }
 
   FPDFBitmap_Destroy(bitmap);
   FORM_DoPageAAction(page, form, FPDFPAGE_AACTION_CLOSE);
   FORM_OnBeforeClosePage(page, form);
   FPDFText_ClosePage(text_page);
   FPDF_ClosePage(page);
   return true;
@@ skipping 183 matching lines @@
     "Usage: pdfium_test [OPTION] [FILE]...\n"
     "  --show-config     - print build options and exit\n"
     "  --bin-dir=<path>  - override path to v8 external data\n"
     "  --font-dir=<path> - override path to external fonts\n"
     "  --scale=<number>  - scale output size by number (e.g. 0.5)\n"
 #ifdef _WIN32
     "  --bmp - write page images <pdf-name>.<page-number>.bmp\n"
     "  --emf - write page meta files <pdf-name>.<page-number>.emf\n"
 #endif  // _WIN32
     "  --png - write page images <pdf-name>.<page-number>.png\n"
+#ifdef _SKIA_SUPPORT_
+    "  --ppm - write page images <pdf-name>.<page-number>.ppm\n"

[Tom Sepez, 2016/03/10 22:55:32]

Why duplicated ppm line in both halves of the ifdef? Can we just move the
semicolon to a line of its own?

[caryclark, 2016/03/11 12:40:34]

The style checker complained when a single semicolon was on a line by itself. I
figured out how to get around this by adding an empty string. (done)

+    "  --skp - write page images <pdf-name>.<page-number>.skp\n";
+#else
     "  --ppm - write page images <pdf-name>.<page-number>.ppm\n";
+#endif
 
 int main(int argc, const char* argv[]) {
   std::vector<std::string> args(argv, argv + argc);
   Options options;
   std::list<std::string> files;
   if (!ParseCommandLine(args, &options, &files)) {
     fprintf(stderr, "%s", usage_string);
     return 1;
   }
 
@@ skipping 51 matching lines @@
   }
 
   FPDF_DestroyLibrary();
 #ifdef PDF_ENABLE_V8
   v8::V8::ShutdownPlatform();
   delete platform;
 #endif  // PDF_ENABLE_V8
 
   return 0;
 }