Fixes depot_tools presubmit

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for depot tools.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
 details on the presubmit API built into depot_tools.
 """
 
@@ skipping 36 matching lines @@
   """
   if input_api.platform == 'win32':
     # Skip for now as long as the test scripts are bash scripts.
     return []
 
   # First loads a local Rietveld instance.
   import sys
   old_sys_path = sys.path
   try:
     sys.path = [input_api.PresubmitLocalPath()] + sys.path
+    print input_api.PresubmitLocalPath()

[Dirk Pranke, 2013/06/26 01:18:44]

I don't think you actually want this print statement ...

[Ryan Tseng, 2013/06/26 01:29:06]

Oops, fixed.

     from testing_support import local_rietveld
     server = local_rietveld.LocalRietveld()
   finally:
     sys.path = old_sys_path
 
   results = []
+  input_api.environ['PATH'] = '%s:%s' % (input_api.PresubmitLocalPath(),

[iannucci, 2013/06/26 01:18:23]

use os.pathsep instead of ':'

[Ryan Tseng, 2013/06/26 01:29:06]

Done.

+                                         input_api.environ['PATH'])
   try:
     # Start a local rietveld instance to test against.
     server.start_server()
     test_path = input_api.os_path.abspath(
         input_api.os_path.join(input_api.PresubmitLocalPath(), 'tests'))
     for test in input_api.os_listdir(test_path):
       # test-lib.sh is not an actual test so it should not be run. The other
       # tests are tests known to fail.
       DISABLED_TESTS = (
           'owners.sh', 'push-from-logs.sh', 'rename.sh', 'test-lib.sh')
       if test in DISABLED_TESTS or not test.endswith('.sh'):
         continue
 
       print('Running %s' % test)
       try:
         if input_api.verbose:
           input_api.subprocess.check_call(
-              [input_api.os_path.join(test_path, test)], cwd=test_path)
+              [input_api.os_path.join(test_path, test)], cwd=test_path,
+              env=input_api.environ)
         else:
           input_api.subprocess.check_output(
               [input_api.os_path.join(test_path, test)], cwd=test_path,
-              stderr=input_api.subprocess.STDOUT)
+              stderr=input_api.subprocess.STDOUT, env=input_api.environ)
       except (OSError, input_api.subprocess.CalledProcessError), e:
         results.append(output_api.PresubmitError('%s failed\n%s' % (test, e)))
   except local_rietveld.Failure, e:
     results.append(output_api.PresubmitError('\n'.join(str(i) for i in e.args)))
   finally:
     server.stop_server()
   return results
 
 
 def CheckChangeOnUpload(input_api, output_api):
   # Do not run integration tests on upload since they are way too slow.
   tests_to_black_list = [
       r'^checkout_test\.py$',
       r'^gclient_smoketest\.py$',
       r'^scm_unittest\.py$',
       r'^subprocess2_test\.py$',
     ]
   return CommonChecks(input_api, output_api, tests_to_black_list)
 
 
 def CheckChangeOnCommit(input_api, output_api):
   output = []
   output.extend(CommonChecks(input_api, output_api, []))
   output.extend(input_api.canned_checks.CheckDoNotSubmit(
       input_api,
       output_api))
   output.extend(RunGitClTests(input_api, output_api))
   return output