Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1776263002:
Handle JS mojo module fetch failures gracefully. (Closed)
|
Created:
4 years, 9 months ago by Sam McNally Modified:
4 years, 9 months ago Reviewers:
Charlie Reis CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionHandle JS mojo module fetch failures gracefully.
Currently, if the fetch of the source for a JS mojo module fails, the
requesting renderer crashes. With this CL, it logs an error instead.
BUG=592831
Committed: https://crrev.com/2eb97bdbc5ebc7fec94c53010b064c677e4cab8f
Cr-Commit-Position: refs/heads/master@{#380528}
Patch Set 1 #
Messages
Total messages: 22 (10 generated)
sammc@chromium.org changed reviewers: + jam@chromium.org
sammc@chromium.org changed reviewers: + creis@chromium.org - jam@chromium.org
-jam (I hear he's OOO) +creis
LGTM
The CQ bit was checked by sammc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776263002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sammc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776263002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sammc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776263002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sammc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776263002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Handle JS mojo module fetch failures gracefully. Currently, if the fetch of the source for a JS mojo module fails, the requesting renderer crashes. With this CL, it logs an error instead. BUG=592831 ========== to ========== Handle JS mojo module fetch failures gracefully. Currently, if the fetch of the source for a JS mojo module fails, the requesting renderer crashes. With this CL, it logs an error instead. BUG=592831 Committed: https://crrev.com/2eb97bdbc5ebc7fec94c53010b064c677e4cab8f Cr-Commit-Position: refs/heads/master@{#380528} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2eb97bdbc5ebc7fec94c53010b064c677e4cab8f Cr-Commit-Position: refs/heads/master@{#380528} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
