Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1776243004: Mojom runtime type info: Use compression and base64 encoding. (Closed)

Created:
4 years, 9 months ago by rudominer
Modified:
4 years, 9 months ago
Reviewers:
zra, azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojom runtime type info: Use compression and base64 encoding. This change decreases the size of the data written into the generated source code that represents a serialized Mojo struct. Previously we were writing a literal array of bytes, written in decimal. Now we have done two things to decrease the size: - We gzip the data - We base64 encode the bytes and write an ascii string literal. The result is that we decrease the size of the data written into the source by a factor of 30 in many cases. BUG=#448 R=azani@chromium.org, zra@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2d4da54579bbcc2b37c28393fab8e3b25aee5e7f

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -457 lines) Patch
M mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart View 2 chunks +8 lines, -16 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import.mojom.dart View 2 chunks +8 lines, -10 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import2.mojom.dart View 2 chunks +8 lines, -7 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/math/math_calculator.mojom.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/examples/echo.mojom.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/rect.mojom.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/serialization_test_structs.mojom.dart View 2 chunks +8 lines, -9 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_enums.mojom.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_included_unions.mojom.dart View 2 chunks +8 lines, -4 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_structs.mojom.dart View 2 chunks +8 lines, -86 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_unions.mojom.dart View 2 chunks +8 lines, -33 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/validation_test_interfaces.mojom.dart View 2 chunks +8 lines, -45 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart View 2 chunks +8 lines, -14 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/regression_tests/regression_tests.mojom.dart View 2 chunks +8 lines, -31 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_factory.mojom.dart View 2 chunks +8 lines, -17 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_interfaces.mojom.dart View 2 chunks +8 lines, -19 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_service.mojom.dart View 2 chunks +8 lines, -32 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart View 2 chunks +8 lines, -12 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_files.mojom.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/mojom_files.mojom View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/dart_templates/module.lib.tmpl View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/dart_templates/module_definition.tmpl View 1 chunk +6 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/generators/go_templates/source.tmpl View 1 chunk +25 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_dart_generator.py View 2 chunks +0 lines, -24 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_go_generator.py View 3 chunks +6 lines, -24 lines 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/generated/mojom_files_mojom.py View 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/generated/mojom_files/mojom_files.mojom.go View 3 chunks +5 lines, -21 lines 0 comments Download
M mojom/mojom_parser/serialization/serialization.go View 2 chunks +17 lines, -2 lines 0 comments Download
M mojom/mojom_parser/serialization/serialization_test.go View 3 chunks +28 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
rudominer
Alex and Zach, ptal.
4 years, 9 months ago (2016-03-10 18:24:18 UTC) #5
zra
lgtm! Does this also fix the problem with the stability of the generated code?
4 years, 9 months ago (2016-03-10 18:41:51 UTC) #6
azani
lgtm
4 years, 9 months ago (2016-03-10 20:51:54 UTC) #7
rudominer
4 years, 9 months ago (2016-03-10 20:58:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as
2d4da54579bbcc2b37c28393fab8e3b25aee5e7f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698