Fix incorrect assertion failures in noopt regarding removing classes that still have constants.

Fix incorrect assertion failures in noopt regarding removing classes that still have constants.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/ed526143225a4f25adeb86f8363f5e7be21d845f

[rmacnak, 2016-03-08 23:57:26]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[rmacnak, 2016-03-08 23:57:27]

https://codereview.chromium.org/1776243002/diff/1/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1776243002/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:1509: I->heap()->CollectAllGarbage();
Is there a better way to wait?

[siva, 2016-03-09 07:03:33]

LGTM with one comment.

https://codereview.chromium.org/1776243002/diff/1/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1776243002/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:1509: I->heap()->CollectAllGarbage();
On 2016/03/08 23:57:27, rmacnak wrote:
> Is there a better way to wait?

You could add a method in heap.h called WaitForSweeperTasks which does something
like
    {
      MonitorLocker ml(old_space_.tasks_lock());
      while (old_space_.tasks() > 0) {
        ml.WaitWithSafepointCheck(thread);
      }
    }

[rmacnak, 2016-03-09 20:09:41]

https://codereview.chromium.org/1776243002/diff/1/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1776243002/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:1509: I->heap()->CollectAllGarbage();
On 2016/03/09 07:03:33, siva wrote:
> On 2016/03/08 23:57:27, rmacnak wrote:
> > Is there a better way to wait?
> 
> You could add a method in heap.h called WaitForSweeperTasks which does
something
> like
>     {
>       MonitorLocker ml(old_space_.tasks_lock());
>       while (old_space_.tasks() > 0) {
>         ml.WaitWithSafepointCheck(thread);
>       }
>     }

Added as debug-only.

[rmacnak, 2016-03-09 20:11:27]

Description was changed from

==========
Fix incorrect assertion failures in noopt regarding removing classes that still
have constants.
==========

to

==========
Fix incorrect assertion failures in noopt regarding removing classes that still
have constants.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ed526143225a4f25adeb86f8363f5e7be21d845f
==========

[rmacnak, 2016-03-09 20:11:28]

Committed patchset #2 (id:20001) manually as
ed526143225a4f25adeb86f8363f5e7be21d845f (presubmit successful).