Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: pkg/unittest/lib/src/core_matchers.dart

Issue 17762004: Fix an error and a warning in unittest. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/unittest/lib/src/interfaces.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/src/core_matchers.dart
===================================================================
--- pkg/unittest/lib/src/core_matchers.dart (revision 24434)
+++ pkg/unittest/lib/src/core_matchers.dart (working copy)
@@ -87,7 +87,7 @@
*/
Matcher equals(expected, [limit=100]) =>
expected is String
- ? new _StringEqualsMatcher(expected)
+ ? new _StringEqualsMatcher(expected)
: new _DeepMatcher(expected, limit);
class _DeepMatcher extends BaseMatcher {
@@ -106,8 +106,8 @@
var actualIterator = actual.iterator;
var index = 0;
while (true) {
+ var newLocation = '${location}[${index}]';
if (expectedIterator.moveNext()) {
- var newLocation = '${location}[${index}]';
if (actualIterator.moveNext()) {
var rp = matcher(expectedIterator.current,
actualIterator.current, newLocation,
@@ -220,7 +220,7 @@
Description describeMismatch(item, Description mismatchDescription,
Map matchState, bool verbose) {
var reason = matchState['reason'];
- // If we didn't get a good reason, that would normally be a
+ // If we didn't get a good reason, that would normally be a
// simple 'is <value>' message. We only add that if the mismatch
// description is non empty (so we are supplementing the mismatch
// description).
« no previous file with comments | « no previous file | pkg/unittest/lib/src/interfaces.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698