Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issue 1776183002: Revert of Use gclient's git_cache setting in bot_update/api.py (Closed)

Created:
4 years, 9 months ago by martiniss
Modified:
4 years, 9 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, wkorman
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Use gclient's git_cache setting in bot_update/api.py (patchset #6 id:100001 of https://codereview.chromium.org/1762513002/ ) Reason for revert: Roll into build breaks infra crons. Original issue's description: > Use gclient's git_cache setting in bot_update/api.py > > BUG=589140 > R=agable@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299120 TBR=agable@chromium.org,hinoka@chromium.org,hinoka@google.com,iannucci@chromium.org,wkorman@chromium.org,szager@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=589140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M recipe_modules/bot_update/api.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/basic_output_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/basic_with_branch_heads.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/clobber.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/forced.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/no_shallow.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/off.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/reset_root_solution_revision.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/svn_mode.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/trychange.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/trychange_oauth2.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_v8.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/gclient/example.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
martiniss
Created Revert of Use gclient's git_cache setting in bot_update/api.py
4 years, 9 months ago (2016-03-08 22:17:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776183002/1
4 years, 9 months ago (2016-03-08 22:17:16 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 22:22:07 UTC) #4
Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

Powered by Google App Engine
This is Rietveld 408576698