Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 1776133003: Have DataObject create less copies of mime type lists. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
dcheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have DataObject create less copies of mime type lists. R=dcheng BUG= Committed: https://crrev.com/89fef21dd6a08763bfedf6a76e6110bb8f9d88b1 Cr-Commit-Position: refs/heads/master@{#380244}

Patch Set 1 #

Patch Set 2 : verify that lists are without duplicates #

Patch Set 3 : iwyu #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M third_party/WebKit/Source/core/clipboard/DataObject.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataObject.cpp View 1 2 2 chunks +20 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransfer.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sof
please take a look. I believe we can avoid using an ordered set for DataObject::types()
4 years, 9 months ago (2016-03-09 10:20:30 UTC) #2
dcheng
On 2016/03/09 at 10:20:30, sigbjornf wrote: > please take a look. > > I believe ...
4 years, 9 months ago (2016-03-09 17:56:39 UTC) #3
sof
On 2016/03/09 17:56:39, dcheng wrote: > On 2016/03/09 at 10:20:30, sigbjornf wrote: > > please ...
4 years, 9 months ago (2016-03-09 19:02:30 UTC) #4
dcheng
lgtm
4 years, 9 months ago (2016-03-09 19:26:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776133003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776133003/40001
4 years, 9 months ago (2016-03-09 20:27:10 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-09 22:35:21 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 22:48:04 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/89fef21dd6a08763bfedf6a76e6110bb8f9d88b1
Cr-Commit-Position: refs/heads/master@{#380244}

Powered by Google App Engine
This is Rietveld 408576698