Source/core/html/HTMLEmbedElement.cpp - Issue 177613003: Consistently cache ElementData::length() before loops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLEmbedElement.cpp

Issue 177613003: Consistently cache ElementData::length() before loops (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix test failure Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLEmbedElement.cpp

diff --git a/Source/core/html/HTMLEmbedElement.cpp b/Source/core/html/HTMLEmbedElement.cpp

index 10dcf7aa2006f28e1c492cecb2e27b3d6412d348..25855fb0a047adee1865d78a2d110503bd1e4952 100644

--- a/Source/core/html/HTMLEmbedElement.cpp

+++ b/Source/core/html/HTMLEmbedElement.cpp

@@ -115,7 +115,8 @@ void HTMLEmbedElement::parametersForPlugin(Vector<String>& paramNames, Vector<St

if (!hasAttributes())

return;

- for (unsigned i = 0; i < attributeCount(); ++i) {

+ unsigned attributeCount = this->attributeCount();

+ for (unsigned i = 0; i < attributeCount; ++i) {

const Attribute* attribute = attributeItem(i);

paramNames.append(attribute->localName().string());

paramValues.append(attribute->value().string());

« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/html/HTMLObjectElement.cpp » ('j') | no next file with comments »