Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: Source/core/html/HTMLEmbedElement.cpp

Issue 177613003: Consistently cache ElementData::length() before loops (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix test failure Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/html/HTMLObjectElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de) 4 * (C) 2000 Stefan Schimanski (1Stein@gmx.de)
5 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2011 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2011 Apple Inc. All rights reserv ed.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 } else { 108 } else {
109 HTMLPlugInElement::parseAttribute(name, value); 109 HTMLPlugInElement::parseAttribute(name, value);
110 } 110 }
111 } 111 }
112 112
113 void HTMLEmbedElement::parametersForPlugin(Vector<String>& paramNames, Vector<St ring>& paramValues) 113 void HTMLEmbedElement::parametersForPlugin(Vector<String>& paramNames, Vector<St ring>& paramValues)
114 { 114 {
115 if (!hasAttributes()) 115 if (!hasAttributes())
116 return; 116 return;
117 117
118 for (unsigned i = 0; i < attributeCount(); ++i) { 118 unsigned attributeCount = this->attributeCount();
119 for (unsigned i = 0; i < attributeCount; ++i) {
119 const Attribute* attribute = attributeItem(i); 120 const Attribute* attribute = attributeItem(i);
120 paramNames.append(attribute->localName().string()); 121 paramNames.append(attribute->localName().string());
121 paramValues.append(attribute->value().string()); 122 paramValues.append(attribute->value().string());
122 } 123 }
123 } 124 }
124 125
125 // FIXME: This should be unified with HTMLObjectElement::updateWidget and 126 // FIXME: This should be unified with HTMLObjectElement::updateWidget and
126 // moved down into HTMLPluginElement.cpp 127 // moved down into HTMLPluginElement.cpp
127 void HTMLEmbedElement::updateWidgetInternal() 128 void HTMLEmbedElement::updateWidgetInternal()
128 { 129 {
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 { 203 {
203 // http://www.whatwg.org/specs/web-apps/current-work/#exposed 204 // http://www.whatwg.org/specs/web-apps/current-work/#exposed
204 for (Node* ancestor = parentNode(); ancestor; ancestor = ancestor->parentNod e()) { 205 for (Node* ancestor = parentNode(); ancestor; ancestor = ancestor->parentNod e()) {
205 if (ancestor->hasTagName(objectTag) && toHTMLObjectElement(ancestor)->is Exposed()) 206 if (ancestor->hasTagName(objectTag) && toHTMLObjectElement(ancestor)->is Exposed())
206 return false; 207 return false;
207 } 208 }
208 return true; 209 return true;
209 } 210 }
210 211
211 } 212 }
OLDNEW
« no previous file with comments | « Source/core/dom/Node.cpp ('k') | Source/core/html/HTMLObjectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698