Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 1776123002: [coverage] Always merge sancov files after testing. (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[coverage] Always merge sancov files after testing. With this, the test runner automatically merges sancov files after testing. There's no need to do this by some external infrastructure. In a future CL, we could even merge during testing to lift harddisk pressure. BUG=chromium:568949 LOG=n NOTRY=true Committed: https://crrev.com/74282397e4f05140564a1f86e364003cbc21eeaf Cr-Commit-Position: refs/heads/master@{#34606}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/run-tests.py View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Michael Achenbach
PTAL
4 years, 9 months ago (2016-03-08 19:58:08 UTC) #4
kjellander_chromium
lgtm with a suggestion https://codereview.chromium.org/1776123002/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/1776123002/diff/1/tools/run-tests.py#newcode835 tools/run-tests.py:835: Maybe you'd want to use ...
4 years, 9 months ago (2016-03-08 20:30:53 UTC) #5
tandrii(chromium)
LGTM % same as Henrik's comment though given that call() doesn't eat stdout/stderr, i believe ...
4 years, 9 months ago (2016-03-08 21:44:54 UTC) #6
Michael Achenbach
Done
4 years, 9 months ago (2016-03-09 08:27:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776123002/20001
4 years, 9 months ago (2016-03-09 08:44:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-09 08:47:01 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 08:48:02 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/74282397e4f05140564a1f86e364003cbc21eeaf
Cr-Commit-Position: refs/heads/master@{#34606}

Powered by Google App Engine
This is Rietveld 408576698