Remove FileException

Remove FileException

The File API no longer uses FileException

http://dev.w3.org/2006/webapi/FileAPI/#dfn-error-codes

Firefox does not implement this interface

BUG=251285
R=ericu@chromium.org, yutak@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153159

[michaeln, 2013-06-25 22:49:40]

ericu said he'd take a look, so swapping reviewers list around

[Yuta Kitamura, 2013-06-26 00:30:01]

modules/websockets LGTM.

[kinuko, 2013-06-26 02:49:33]

looks good, but doesn't this break existing app behavior?

[arv (Not doing code reviews), 2013-06-26 03:09:54]

Firefox does this already. Generally web content does not check instanceof
or the deprecated code property, they just catch the exception, not
worrying much about what exception it is.
On Jun 25, 2013 10:49 PM, <kinuko@chromium.org> wrote:

> looks good, but doesn't this break existing app behavior?
>
>
https://codereview.chromium.**org/17761003/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2013-06-26 14:20:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arv@chromium.org/17761003/2001

[commit-bot: I haz the power, 2013-06-26 14:20:10]

Failed to apply patch for
LayoutTests/webexposed/global-constructors-listing-worker-expected.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
  |diff --git
a/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
b/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
  |index
e1414fe179c061386a73f30343915a19acdfc114..d9b63859ebd5163ab70afde5dfa655938146e8cc
100644
  |--- a/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
  |+++ b/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:      
LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
Index: LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
diff --git
a/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
b/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
index
e1414fe179c061386a73f30343915a19acdfc114..d9b63859ebd5163ab70afde5dfa655938146e8cc
100644
--- a/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
+++ b/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
@@ -14,7 +14,6 @@ Starting worker:
resources/global-context-constructors-listing.js
 [Worker] EvalError
 [Worker] EventSource
 [Worker] FileError
-[Worker] FileException
 [Worker] FileReader
 [Worker] FileReaderSync
 [Worker] Float32Array

[commit-bot: I haz the power, 2013-06-26 16:53:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arv@chromium.org/17761003/11001

[commit-bot: I haz the power, 2013-06-26 16:53:18]

Failed to apply patch for
LayoutTests/webexposed/global-constructors-listing-worker-expected.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
  |diff --git
a/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
b/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
  |index
e1414fe179c061386a73f30343915a19acdfc114..d9b63859ebd5163ab70afde5dfa655938146e8cc
100644
  |--- a/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
  |+++ b/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:      
LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
Index: LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
diff --git
a/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
b/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
index
e1414fe179c061386a73f30343915a19acdfc114..d9b63859ebd5163ab70afde5dfa655938146e8cc
100644
--- a/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
+++ b/LayoutTests/webexposed/global-constructors-listing-worker-expected.txt
@@ -14,7 +14,6 @@ Starting worker:
resources/global-context-constructors-listing.js
 [Worker] EvalError
 [Worker] EventSource
 [Worker] FileError
-[Worker] FileException
 [Worker] FileReader
 [Worker] FileReaderSync
 [Worker] Float32Array

[commit-bot: I haz the power, 2013-06-26 17:07:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arv@chromium.org/17761003/15001

[commit-bot: I haz the power, 2013-06-26 17:15:59]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[commit-bot: I haz the power, 2013-06-26 18:33:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arv@chromium.org/17761003/13003

[commit-bot: I haz the power, 2013-06-26 18:42:31]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[ericu, 2013-06-27 00:01:39]

LGTM.

This is long been a TODO on my low-priority list.  Thanks for doing the cleanup.

This does change user-visible behavior, though.  What's your plan for warning
users about the change?

[commit-bot: I haz the power, 2013-06-27 13:47:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arv@chromium.org/17761003/13003

[commit-bot: I haz the power, 2013-06-27 14:29:01]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_layout_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-27 15:04:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arv@chromium.org/17761003/45001

[commit-bot: I haz the power, 2013-06-27 17:03:25]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[arv (Not doing code reviews), 2013-06-27 17:13:35]

Committed patchset #6 manually as r153159 (presubmit successful).