Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 1776033002: Implement MojoGetBufferInformation(), part 1. (Closed)

Created:
4 years, 9 months ago by viettrungluu
Modified:
4 years, 9 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Implement MojoGetBufferInformation(), part 1. This implements it at the Dispatcher level; it still needs to be plumbed into Core and then the thunk table (and the NaCl SFI equivalent?). R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/63d9b93828f83a628dbeae7e3da907a007c5b3f3

Patch Set 1 #

Total comments: 1

Patch Set 2 : doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -16 lines) Patch
M mojo/edk/system/dispatcher.h View 2 chunks +5 lines, -0 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M mojo/edk/system/dispatcher_unittest.cc View 5 chunks +36 lines, -8 lines 0 comments Download
M mojo/edk/system/memory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.cc View 1 1 chunk +23 lines, -0 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher_unittest.cc View 2 chunks +37 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 9 months ago (2016-03-08 18:11:28 UTC) #1
vardhan
lgtm https://codereview.chromium.org/1776033002/diff/1/mojo/edk/system/shared_buffer_dispatcher.cc File mojo/edk/system/shared_buffer_dispatcher.cc (right): https://codereview.chromium.org/1776033002/diff/1/mojo/edk/system/shared_buffer_dispatcher.cc#newcode241 mojo/edk/system/shared_buffer_dispatcher.cc:241: // definition, more work will be necessary. (See ...
4 years, 9 months ago (2016-03-08 21:36:57 UTC) #2
viettrungluu
Thanks. On 2016/03/08 21:36:57, vardhan wrote: > lgtm > > https://codereview.chromium.org/1776033002/diff/1/mojo/edk/system/shared_buffer_dispatcher.cc > File mojo/edk/system/shared_buffer_dispatcher.cc (right): ...
4 years, 9 months ago (2016-03-08 21:43:46 UTC) #3
viettrungluu
4 years, 9 months ago (2016-03-08 21:44:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
63d9b93828f83a628dbeae7e3da907a007c5b3f3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698