Add AnalysisContext.onResultInvalidated(descriptor).

Add AnalysisContext.onResultInvalidated(descriptor).

This method will be used to remove index entries corresponding to
invalidated resolved units.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/3af20476d137b4eb3bec75441001fd846c24f77e

[Brian Wilkerson, 2016-03-08 17:54:31]

https://codereview.chromium.org/1776023002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1776023002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:2070: class InvalidatedResult<V> {
Maybe rename to InvalidatedResultEvent?

https://codereview.chromium.org/1776023002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:2074: final CacheEntry entry;
I really don't want CacheEntry to be part of the public API. What information
from it are you expecting to need? Is it just the target, as implied by the
comment?

https://codereview.chromium.org/1776023002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:2082: * The value of the result which
was invalidated.
"which was" --> "before it was"?

https://codereview.chromium.org/1776023002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:2089: String toString() =>
'$descriptor of ${entry.target}';
"'$d" --> "'Invalidated $d"? Otherwise it's too close to ComputedResult.
Speaking of which, maybe this object should contain a computed result and a
value instead of the current properties.

[scheglov, 2016-03-08 18:24:45]

PTAL

https://codereview.chromium.org/1776023002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1776023002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:2070: class InvalidatedResult<V> {
On 2016/03/08 17:54:31, Brian Wilkerson wrote:
> Maybe rename to InvalidatedResultEvent?

Done.

https://codereview.chromium.org/1776023002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:2074: final CacheEntry entry;
On 2016/03/08 17:54:31, Brian Wilkerson wrote:
> I really don't want CacheEntry to be part of the public API. What information
> from it are you expecting to need? Is it just the target, as implied by the
> comment?

I changed the set of fields to be like in ComputedResult, so now it does not
expose CacheEntry.

https://codereview.chromium.org/1776023002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:2082: * The value of the result which
was invalidated.
On 2016/03/08 17:54:31, Brian Wilkerson wrote:
> "which was" --> "before it was"?

Done.

https://codereview.chromium.org/1776023002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:2089: String toString() =>
'$descriptor of ${entry.target}';
On 2016/03/08 17:54:31, Brian Wilkerson wrote:
> "'$d" --> "'Invalidated $d"? Otherwise it's too close to ComputedResult.
> Speaking of which, maybe this object should contain a computed result and a
> value instead of the current properties.

Done.

[Brian Wilkerson, 2016-03-08 18:36:36]

https://codereview.chromium.org/1776023002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1776023002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/engine.dart:2071: class InvalidatedResultEvent<V>
{
Given that it's now identical to ComputedResult (except for toString), I have to
wonder whether there's any value in adding a new class.

I'd recommend generalizing this:
- rename this class to ResultChange (or ResultChangedEvent),
- rename the method to onResultChanged, and
- add two getters wasComputed and wasInvalidated (with a private field).

It would be a breaking change to remove ComputedResult, but we could deprecate
both it and onResultComputed.

[scheglov, 2016-03-08 20:33:27]

PTAL

[Brian Wilkerson, 2016-03-08 20:47:02]

LGTM

https://codereview.chromium.org/1776023002/diff/60001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1776023002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/engine.dart:2463: String toString() =>
'$descriptor of $target';
" in $context"?

[scheglov, 2016-03-08 20:53:46]

https://codereview.chromium.org/1776023002/diff/60001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1776023002/diff/60001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/engine.dart:2463: String toString() =>
'$descriptor of $target';
On 2016/03/08 20:47:02, Brian Wilkerson wrote:
> " in $context"?

Done.

[scheglov, 2016-03-08 20:55:12]

Description was changed from

==========
Add AnalysisContext.onResultInvalidated(descriptor).

This method will be used to remove index entries corresponding to
invalidated resolved units.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Add AnalysisContext.onResultInvalidated(descriptor).

This method will be used to remove index entries corresponding to
invalidated resolved units.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/3af20476d137b4eb3bec75441001fd846c24f77e
==========

[scheglov, 2016-03-08 20:55:14]

Committed patchset #4 (id:60001) manually as
3af20476d137b4eb3bec75441001fd846c24f77e (presubmit successful).