Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 1776013003: [regexp] fix bogus assertion in CharacterRange constructor. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] fix bogus assertion in CharacterRange constructor. The CharacterRange constructor checks the input for validity. However, CharacterRange::Singleton also uses the constructor and may have kEndMarker as input, causing the check to fail. The solution is to move the check to CharacterRange::Range and consistently use it across the code base. R=jkummerow@chromium.org BUG=chromium:593282 LOG=N Committed: https://crrev.com/d1f68f776eafa62d4bd1cc3465d18c2e47473381 Cr-Commit-Position: refs/heads/master@{#34626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -63 lines) Patch
M src/regexp/jsregexp.cc View 12 chunks +27 lines, -24 lines 0 comments Download
M src/regexp/regexp-ast.h View 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-regexp.cc View 8 chunks +37 lines, -35 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-593282.js View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Yang
4 years, 9 months ago (2016-03-09 12:16:56 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776013003/1
4 years, 9 months ago (2016-03-09 12:18:03 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 12:40:54 UTC) #6
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-09 15:46:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1776013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1776013003/1
4 years, 9 months ago (2016-03-09 15:51:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 15:55:03 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 15:55:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1f68f776eafa62d4bd1cc3465d18c2e47473381
Cr-Commit-Position: refs/heads/master@{#34626}

Powered by Google App Engine
This is Rietveld 408576698