[turbofan] Fix deoptimization stack layout for fast literal comparisons.

[turbofan] Fix deoptimization stack layout for fast literal comparisons.

BUG=chromium:592341
LOG=n

Committed: https://crrev.com/69c84fe460ee20cd16923aa2a20058a998086322
Cr-Commit-Position: refs/heads/master@{#34615}

[Jarin, 2016-03-08 17:37:57]

jarin@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Jarin, 2016-03-08 17:37:57]

Could you take a look, please?

[Michael Starzinger, 2016-03-09 09:26:14]

LGTM.

https://codereview.chromium.org/1776013002/diff/20001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1776013002/diff/20001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:2849: NewNode(javascript()->Equal(),
typeof_arg, jsgraph()->Constant(check));
nit: This could be made StrictEqual I think, WDYT?

https://codereview.chromium.org/1776013002/diff/20001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.h (right):

https://codereview.chromium.org/1776013002/diff/20001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.h:421: void VisitTypeofExpression(Expression*
expr);
nit: Can we separate out this last function from the rest and add a comment "//
Dispatched from VisitTypeof." in front?

[Jarin, 2016-03-09 10:50:18]

https://codereview.chromium.org/1776013002/diff/20001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/1776013002/diff/20001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:2849: NewNode(javascript()->Equal(),
typeof_arg, jsgraph()->Constant(check));
On 2016/03/09 09:26:14, Michael Starzinger wrote:
> nit: This could be made StrictEqual I think, WDYT?

Agreed, changed.

https://codereview.chromium.org/1776013002/diff/20001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.h (right):

https://codereview.chromium.org/1776013002/diff/20001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.h:421: void VisitTypeofExpression(Expression*
expr);
On 2016/03/09 09:26:14, Michael Starzinger wrote:
> nit: Can we separate out this last function from the rest and add a comment
"//
> Dispatched from VisitTypeof." in front?

Done.

[Jarin, 2016-03-09 12:27:41]

The CQ bit was checked by jarin@chromium.org

[Jarin, 2016-03-09 12:27:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1776013002/#ps40001
(title: "Address review comments")

[commit-bot: I haz the power, 2016-03-09 12:27:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776013002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776013002/40001

[commit-bot: I haz the power, 2016-03-09 12:35:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-09 12:36:15]

Description was changed from

==========
[turbofan] Fix deoptimization stack layout for fast literal comparisons.

BUG=chromium:592341
LOG=n
==========

to

==========
[turbofan] Fix deoptimization stack layout for fast literal comparisons.

BUG=chromium:592341
LOG=n

Committed: https://crrev.com/69c84fe460ee20cd16923aa2a20058a998086322
Cr-Commit-Position: refs/heads/master@{#34615}
==========

[commit-bot: I haz the power, 2016-03-09 12:36:16]

Patchset 3 (id:??) landed as
https://crrev.com/69c84fe460ee20cd16923aa2a20058a998086322
Cr-Commit-Position: refs/heads/master@{#34615}