Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 17760008: [SPDY] Enable tests for SPDY/3.1 and SPDY/4 (Closed)

Created:
7 years, 6 months ago by akalin
Modified:
7 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

[SPDY] Enable tests for SPDY/3.1 and SPDY/4a2 Make the sending of the initial stream window size part of SpdySession::SendInitialSettings(). Since this is already turned off for tests, this makes it a lot easier to enable tests for SPDY/3.1 and above, since we don't have to conditionally expect the initial WINDOW_UPDATE frame. Actually test handling of Alternate-Protocol header in http_network_transaction_unittest.cc. Fix handling of SPDY/3.1 and above in AlternateProtocolToString() and HttpStreamFactoryImpl::GetAlternateProtocolRequestFor(). Other misc. cleanup. BUG=230124 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208997

Patch Set 1 #

Patch Set 2 : Fix more tests #

Total comments: 6

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -938 lines) Patch
M net/http/http_network_transaction_unittest.cc View 1 53 chunks +55 lines, -127 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 6 chunks +0 lines, -18 lines 0 comments Download
M net/http/http_server_properties.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/http_server_properties.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M net/socket/next_proto.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 1 2 9 chunks +3 lines, -28 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 2 101 chunks +136 lines, -372 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M net/spdy/spdy_session.cc View 3 chunks +16 lines, -14 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 2 68 chunks +85 lines, -226 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 21 chunks +12 lines, -118 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 3 chunks +9 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 3 chunks +32 lines, -0 lines 0 comments Download
M net/spdy/spdy_websocket_stream_unittest.cc View 4 chunks +0 lines, -15 lines 0 comments Download
M net/websockets/websocket_job_unittest.cc View 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
akalin
+rch for review forgot to send this out!
7 years, 6 months ago (2013-06-26 17:34:48 UTC) #1
Ryan Hamilton
The changes I have reviewed look good, but there are a couple of place where ...
7 years, 5 months ago (2013-06-27 17:23:50 UTC) #2
akalin
PTAL https://codereview.chromium.org/17760008/diff/5001/net/spdy/spdy_network_transaction_unittest.cc File net/spdy/spdy_network_transaction_unittest.cc (left): https://codereview.chromium.org/17760008/diff/5001/net/spdy/spdy_network_transaction_unittest.cc#oldcode2253 net/spdy/spdy_network_transaction_unittest.cc:2253: // Test that sent data frames and received ...
7 years, 5 months ago (2013-06-27 20:00:06 UTC) #3
Ryan Hamilton
lgtm. feel free to land a follow up cl that simply moves that code around.
7 years, 5 months ago (2013-06-27 20:39:44 UTC) #4
akalin
7 years, 5 months ago (2013-06-27 20:52:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r208997 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698