Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: components/webdata/common/web_data_service_base.h

Issue 17760007: components/webdata: Cleanup callback usage in WebDatabaseService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: disallow Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/webdata/common/web_data_service_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/webdata/common/web_data_service_base.h
diff --git a/components/webdata/common/web_data_service_base.h b/components/webdata/common/web_data_service_base.h
index 7a2d6bf86ec3426d79e343c437973cef65f3d722..3a39622941569ecc0c4adb8fee2385a8bff85d21 100644
--- a/components/webdata/common/web_data_service_base.h
+++ b/components/webdata/common/web_data_service_base.h
@@ -36,6 +36,8 @@ class WEBDATA_EXPORT WebDataServiceBase
// TODO(joi): Should we combine this with WebDatabaseService::InitCallback?
typedef base::Callback<void(sql::InitStatus)> ProfileErrorCallback;
+ typedef base::Closure DBLoadedCallback;
+
// |callback| will only be invoked on error, and only if
// |callback.is_null()| evaluates to false.
//
@@ -72,8 +74,7 @@ class WEBDATA_EXPORT WebDataServiceBase
// (following a successful database load), then cleared.
// Note: if the database load is already complete, then the callback will NOT
// be stored or called.
- virtual void RegisterDBLoadedCallback(
- const base::Callback<void(void)>& callback);
+ virtual void RegisterDBLoadedCallback(const DBLoadedCallback& callback);
// Returns true if the database load has completetd successfully, and
// ShutdownOnUIThread has not yet been called.
@@ -95,6 +96,8 @@ class WEBDATA_EXPORT WebDataServiceBase
private:
ProfileErrorCallback profile_error_callback_;
+
+ DISALLOW_COPY_AND_ASSIGN(WebDataServiceBase);
};
#endif // COMPONENTS_WEBDATA_COMMON_WEB_DATA_SERVICE_BASE_H_
« no previous file with comments | « no previous file | components/webdata/common/web_data_service_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698