Issue 17760007: components/webdata: Cleanup callback usage in WebDatabaseService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17760007: components/webdata: Cleanup callback usage in WebDatabaseService. (Closed)

Created:
7 years, 6 months ago by tfarina

Modified:
7 years, 5 months ago

Reviewers:
Cait (Slow), Jói

CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org, Cait (Slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

components/webdata: Cleanup callback usage in WebDatabaseService. And also in WebDataServiceBase. BUG=181277 R=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209378

Patch Set 1 #

Patch Set 2 : disallow #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -16 lines)			Patch
M	components/webdata/common/web_data_service_base.h	View	1	3 chunks	+5 lines, -2 lines	0 comments	Download
M	components/webdata/common/web_data_service_base.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	components/webdata/common/web_database_service.h	View		5 chunks	+12 lines, -11 lines	0 comments	Download
M	components/webdata/common/web_database_service.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/17760007/2001

7 years, 5 months ago (2013-06-30 02:30:40 UTC) #4

Message was sent while issue was closed.

Change committed as 209378

Expand Messages | Collapse Messages