Add hacks into build_sdk_summaries to workaround bugs in build tools.

Add hacks into build_sdk_summaries to workaround bugs in build tools.

Paul thinks that there is a bug in gyp or make, and we should generate
only one output. So, we generate the whole bundle with all summaries
and index information. And then we have separate actions that take
this bundle and extract one output each - spec.sum and strong.sum files.

R=paulberry@google.com, whesse@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/5a927c7373b579182ddab9aab798ca934a47520a

[Paul Berry, 2016-03-09 18:23:21]

lgtm.

As a future improvement, consider the following organization:

- generate_spec_summary_bundle: analyzes SDK in spec mode and generates a bundle
containing spec.sum and spec.index

- generate_sound_summary_bundle: analyzes SDK in sound mode and generates a
bundle containing sound.sum and sound.index

- extract_spec_summary: extracts spec.sum from the output of
generate_spec_summary_bundle

- extract_spec_index: extracts spec.index from the output of
generate_spec_summary_bundle

- extract_sound_summary: extracts sound.sum from the output of
generate_sound_summary_bundle

- extract_sound_index: extracts sound.index from the output of
generate_sound_summary_bundle

That way the two slow steps (analyzing the SDK in spec mode and analyzing it in
strong mode) can happen in parallel during the build rather than serially.

https://codereview.chromium.org/1775973003/diff/1/pkg/analyzer/tool/summary/b...
File pkg/analyzer/tool/summary/build_sdk_summaries.dart (right):

https://codereview.chromium.org/1775973003/diff/1/pkg/analyzer/tool/summary/b...
pkg/analyzer/tool/summary/build_sdk_summaries.dart:22: if (command ==
'multiple-outputs') {
Add `&& args.length >= 2 && args.length <= 3`.  Otherwise passing too few args
could cause a crash, and passing too many arguments will cause the extra
arguments to be ignored.

https://codereview.chromium.org/1775973003/diff/1/pkg/analyzer/tool/summary/b...
pkg/analyzer/tool/summary/build_sdk_summaries.dart:47: } else if (command ==
'single-output') {
Same comment here.

[Paul Berry, 2016-03-09 18:28:30]

I've verified that this fixes https://github.com/dart-lang/sdk/issues/25851 on
my Linux machine.

[scheglov, 2016-03-09 19:37:20]

Description was changed from

==========
Add hacks into build_sdk_summaries to workaround bugs in build tools.

Paul thinks that there is a bug in gyp or make, and we should generate
only one output. So, we generate the whole bundle with all summaries
and index information. And then we have separate actions that take
this bundle and extract one output each - spec.sum and strong.sum files.

R=paulberry@google.com,whesse@google.com
BUG=
==========

to

==========
Add hacks into build_sdk_summaries to workaround bugs in build tools.

Paul thinks that there is a bug in gyp or make, and we should generate
only one output. So, we generate the whole bundle with all summaries
and index information. And then we have separate actions that take
this bundle and extract one output each - spec.sum and strong.sum files.

R=paulberry@google.com, whesse@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/5a927c7373b579182ddab9aab798ca934a47520a
==========

[scheglov, 2016-03-09 19:37:21]

Committed patchset #1 (id:1) manually as
5a927c7373b579182ddab9aab798ca934a47520a (presubmit successful).