Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1523)

Unified Diff: test/cctest/test-parsing.cc

Issue 1775973002: Add GetProperty/GetElement to JSReceiver and use it where possible (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-object-observe.cc ('k') | test/unittests/compiler/js-builtin-reducer-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index ccd2ec8ca2e41d6a731848e5f335e07738f7f626..fb18acedaad6e9432aa3a176e9c45bbebe987ca6 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -1599,9 +1599,9 @@ void TestParserSyncWithFlags(i::Handle<i::String> source,
CHECK(isolate->has_pending_exception());
i::Handle<i::JSObject> exception_handle(
i::JSObject::cast(isolate->pending_exception()));
- i::Handle<i::String> message_string =
- i::Handle<i::String>::cast(i::Object::GetProperty(
- isolate, exception_handle, "message").ToHandleChecked());
+ i::Handle<i::String> message_string = i::Handle<i::String>::cast(
+ i::JSReceiver::GetProperty(isolate, exception_handle, "message")
+ .ToHandleChecked());
if (result == kSuccess) {
v8::base::OS::Print(
@@ -5742,9 +5742,9 @@ TEST(BasicImportExportParsing) {
if (!parser.Parse(&info)) {
i::Handle<i::JSObject> exception_handle(
i::JSObject::cast(isolate->pending_exception()));
- i::Handle<i::String> message_string =
- i::Handle<i::String>::cast(i::Object::GetProperty(
- isolate, exception_handle, "message").ToHandleChecked());
+ i::Handle<i::String> message_string = i::Handle<i::String>::cast(
+ i::JSReceiver::GetProperty(isolate, exception_handle, "message")
+ .ToHandleChecked());
v8::base::OS::Print(
"Parser failed on:\n"
« no previous file with comments | « test/cctest/test-object-observe.cc ('k') | test/unittests/compiler/js-builtin-reducer-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698