Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: test/cctest/test-compiler.cc

Issue 1775973002: Add GetProperty/GetElement to JSReceiver and use it where possible (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/heap/test-heap.cc ('k') | test/cctest/test-object-observe.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-compiler.cc
diff --git a/test/cctest/test-compiler.cc b/test/cctest/test-compiler.cc
index 587bbfece71e80a216de759a2201d5ab00a0ca3d..1dd46bec3e1ce4945c37e12ad5a35f1198918c91 100644
--- a/test/cctest/test-compiler.cc
+++ b/test/cctest/test-compiler.cc
@@ -39,8 +39,8 @@ using namespace v8::internal;
static Handle<Object> GetGlobalProperty(const char* name) {
Isolate* isolate = CcTest::i_isolate();
- return Object::GetProperty(
- isolate, isolate->global_object(), name).ToHandleChecked();
+ return JSReceiver::GetProperty(isolate, isolate->global_object(), name)
+ .ToHandleChecked();
}
@@ -227,10 +227,9 @@ TEST(C2JSFrames) {
Handle<JSObject> global(isolate->context()->global_object());
Execution::Call(isolate, fun0, global, 0, NULL).Check();
- Handle<String> foo_string =
- isolate->factory()->InternalizeOneByteString(STATIC_CHAR_VECTOR("foo"));
- Handle<Object> fun1 = Object::GetProperty(
- isolate->global_object(), foo_string).ToHandleChecked();
+ Handle<Object> fun1 =
+ JSReceiver::GetProperty(isolate, isolate->global_object(), "foo")
+ .ToHandleChecked();
CHECK(fun1->IsJSFunction());
Handle<Object> argv[] = {isolate->factory()->InternalizeOneByteString(
« no previous file with comments | « test/cctest/heap/test-heap.cc ('k') | test/cctest/test-object-observe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698