Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: src/core/SkLinearBitmapPipeline.h

Issue 1775963002: Bilerp + mirror + perspective (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Address comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkBitmapProcState.cpp ('k') | src/core/SkLinearBitmapPipeline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkLinearBitmapPipeline.h
diff --git a/src/core/SkLinearBitmapPipeline.h b/src/core/SkLinearBitmapPipeline.h
index c65b7538aa3a2f6962ce11f6005e3c28553f81f8..7efdd1c6fb19a971107175546ae2b4a2b37637ed 100644
--- a/src/core/SkLinearBitmapPipeline.h
+++ b/src/core/SkLinearBitmapPipeline.h
@@ -21,6 +21,7 @@ public:
const SkMatrix& inverse,
SkFilterQuality filterQuality,
SkShader::TileMode xTile, SkShader::TileMode yTile,
+ float postAlpha,
const SkPixmap& srcPixmap);
~SkLinearBitmapPipeline();
@@ -33,7 +34,7 @@ public:
~PolymorphicUnion() {
if (fIsInitialized) {
- get()->~Base();
+ this->get()->~Base();
}
}
@@ -47,8 +48,8 @@ public:
};
Base* get() const { return reinterpret_cast<Base*>(&fSpace); }
- Base* operator->() const { return get(); }
- Base& operator*() const { return *get(); }
+ Base* operator->() const { return this->get(); }
+ Base& operator*() const { return *(this->get()); }
private:
struct SK_STRUCT_ALIGN(16) Space {
@@ -62,18 +63,16 @@ public:
class BilerpProcessorInterface;
class PixelPlacerInterface;
- using MatrixStage = PolymorphicUnion<PointProcessorInterface, 112>;
- using FilterStage = PolymorphicUnion<PointProcessorInterface, 8>;
- using TileStage = PolymorphicUnion<BilerpProcessorInterface, 96>;
+ // These values were generated by the assert above in PolymorphicUnion.
+ using MatrixStage = PolymorphicUnion<PointProcessorInterface, 160>;
+ using TileStage = PolymorphicUnion<PointProcessorInterface, 160>;
using SampleStage = PolymorphicUnion<BilerpProcessorInterface, 80>;
using PixelStage = PolymorphicUnion<PixelPlacerInterface, 80>;
private:
PointProcessorInterface* fFirstStage;
MatrixStage fMatrixStage;
- FilterStage fFilterStage;
- TileStage fTileXOrBothStage;
- TileStage fTileYStage;
+ TileStage fTiler;
SampleStage fSampleStage;
PixelStage fPixelStage;
};
« no previous file with comments | « src/core/SkBitmapProcState.cpp ('k') | src/core/SkLinearBitmapPipeline.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698