content/common/bluetooth/bluetooth_service.mojom - Issue 1775953004: bluetooth: Move writeValue to mojo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/bluetooth/bluetooth_service.mojom

Issue 1775953004: bluetooth: Move writeValue to mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Moar cleanup Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module content.mojom;
	Ken Rockot(use gerrit already) 2016/03/09 19:31:26 Hmm. I understand you want to port to mojo first, Hmm. I understand you want to port to mojo first, then move to blink, but I wonder if there's any harm in just starting this mojom in blink. Even if the impl is in content/browser and the client is in content/renderer, it's going to be much less churn later (namespace changes, build changes, header changes...). ortuno 2016/03/16 16:29:45 Done. Show quoted text On 2016/03/09 at 19:31:26, Ken Rockot wrote: > Hmm. I understand you want to port to mojo first, then move to blink, but I wonder if there's any harm in just starting this mojom in blink. Even if the impl is in content/browser and the client is in content/renderer, it's going to be much less churn later (namespace changes, build changes, header changes...). Done.
	6

	7 import "third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom ";

	8

	9 interface BluetoothService {

	10

	11 RemoteCharacteristicWriteValue(

	12 int32 frame_routing_id,

	13 string characteristic_instance_id,

	14 array<uint8> value) => (blink.mojom.WebBluetoothError error);

	15 };

OLD	NEW