Reland Trace FrameTreeNode Snapshots

content/browser/frame_host/frame_tree_node.cc

Index: content/browser/frame_host/frame_tree_node.cc
diff --git a/content/browser/frame_host/frame_tree_node.cc b/content/browser/frame_host/frame_tree_node.cc
index f9b793fb35a6029e20962ba2b6c8b00449097fd9..0bee19339e55566e8bd16919045236baf86fc75f 100644
--- a/content/browser/frame_host/frame_tree_node.cc
+++ b/content/browser/frame_host/frame_tree_node.cc
@@ -14,6 +14,7 @@
 #include "content/browser/frame_host/navigation_request.h"
 #include "content/browser/frame_host/navigator.h"
 #include "content/browser/frame_host/render_frame_host_impl.h"
+#include "content/browser/frame_host/traced_frame_tree_node.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/common/frame_messages.h"
 #include "content/common/site_isolation_policy.h"
@@ -105,6 +106,13 @@ FrameTreeNode::FrameTreeNode(
       g_frame_tree_node_id_map.Get().insert(
           std::make_pair(frame_tree_node_id_, this));
   CHECK(result.second);
+
+  TRACE_EVENT_OBJECT_CREATED_WITH_ID(
+      "navigation", "FrameTreeNode",
+      TRACE_ID_WITH_SCOPE("FrameTreeNode", frame_tree_node_id_));
+  // Don't TraceSnapshot() until the RenderManager is initialized and

[nasko, 2016/03/09 22:33:00]

nit: |RenderManager| is not the name of a type that exists, did you mean
RenderFrameHostManager?

[benjhayden, 2016/03/10 00:05:21]

Done.

+  // calls SetCurrentURL().
+  base::trace_event::TraceLog::GetInstance()->AddEnabledStateObserver(this);
 }
 
 FrameTreeNode::~FrameTreeNode() {
@@ -116,6 +124,11 @@ FrameTreeNode::~FrameTreeNode() {
     opener_->RemoveObserver(opener_observer_.get());
 
   g_frame_tree_node_id_map.Get().erase(frame_tree_node_id_);
+
+  TRACE_EVENT_OBJECT_DELETED_WITH_ID(
+      "navigation", "FrameTreeNode",
+      TRACE_ID_WITH_SCOPE("FrameTreeNode", frame_tree_node_id_));
+  base::trace_event::TraceLog::GetInstance()->RemoveEnabledStateObserver(this);
 }
 
 void FrameTreeNode::AddObserver(Observer* observer) {
@@ -172,6 +185,7 @@ void FrameTreeNode::RemoveChild(FrameTreeNode* child) {
 
 void FrameTreeNode::ResetForNewProcess() {
   current_frame_host()->set_last_committed_url(GURL());
+  TraceSnapshot();
 
   // Remove child nodes from the tree, then delete them. This destruction
   // operation will notify observers.
@@ -197,6 +211,7 @@ void FrameTreeNode::SetCurrentURL(const GURL& url) {
   if (!has_committed_real_load_ && url != GURL(url::kAboutBlankURL))
     has_committed_real_load_ = true;
   current_frame_host()->set_last_committed_url(url);
+  TraceSnapshot();
 }
 
 void FrameTreeNode::SetCurrentOrigin(const url::Origin& origin) {
@@ -448,4 +463,16 @@ void FrameTreeNode::BeforeUnloadCanceled() {
   }
 }
 
+void FrameTreeNode::OnTraceLogEnabled() {
+  TraceSnapshot();
+}
+
+void FrameTreeNode::TraceSnapshot() const {
+  TRACE_EVENT_OBJECT_SNAPSHOT_WITH_ID(
+      "navigation", "FrameTreeNode",
+      TRACE_ID_WITH_SCOPE("FrameTreeNode", frame_tree_node_id_),
+      scoped_ptr<base::trace_event::ConvertableToTraceFormat>(
+          new TracedFrameTreeNode(*this)));
+}
+
 }  // namespace content