Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: content/browser/frame_host/frame_tree_node.cc

Issue 1775953003: Reland Trace FrameTreeNode Snapshots (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/frame_tree_node.h" 5 #include "content/browser/frame_host/frame_tree_node.h"
6 6
7 #include <queue> 7 #include <queue>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/profiler/scoped_tracker.h" 11 #include "base/profiler/scoped_tracker.h"
12 #include "base/stl_util.h" 12 #include "base/stl_util.h"
13 #include "content/browser/frame_host/frame_tree.h" 13 #include "content/browser/frame_host/frame_tree.h"
14 #include "content/browser/frame_host/navigation_request.h" 14 #include "content/browser/frame_host/navigation_request.h"
15 #include "content/browser/frame_host/navigator.h" 15 #include "content/browser/frame_host/navigator.h"
16 #include "content/browser/frame_host/render_frame_host_impl.h" 16 #include "content/browser/frame_host/render_frame_host_impl.h"
17 #include "content/browser/frame_host/traced_frame_tree_node.h"
17 #include "content/browser/renderer_host/render_view_host_impl.h" 18 #include "content/browser/renderer_host/render_view_host_impl.h"
18 #include "content/common/frame_messages.h" 19 #include "content/common/frame_messages.h"
19 #include "content/common/site_isolation_policy.h" 20 #include "content/common/site_isolation_policy.h"
20 #include "content/public/browser/browser_thread.h" 21 #include "content/public/browser/browser_thread.h"
21 #include "content/public/common/browser_side_navigation_policy.h" 22 #include "content/public/common/browser_side_navigation_policy.h"
22 #include "third_party/WebKit/public/web/WebSandboxFlags.h" 23 #include "third_party/WebKit/public/web/WebSandboxFlags.h"
23 24
24 namespace content { 25 namespace content {
25 26
26 namespace { 27 namespace {
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 unique_name, 99 unique_name,
99 blink::WebSandboxFlags::None, 100 blink::WebSandboxFlags::None,
100 false /* should enforce strict mixed content checking */), 101 false /* should enforce strict mixed content checking */),
101 pending_sandbox_flags_(blink::WebSandboxFlags::None), 102 pending_sandbox_flags_(blink::WebSandboxFlags::None),
102 frame_owner_properties_(frame_owner_properties), 103 frame_owner_properties_(frame_owner_properties),
103 loading_progress_(kLoadingProgressNotStarted) { 104 loading_progress_(kLoadingProgressNotStarted) {
104 std::pair<FrameTreeNodeIdMap::iterator, bool> result = 105 std::pair<FrameTreeNodeIdMap::iterator, bool> result =
105 g_frame_tree_node_id_map.Get().insert( 106 g_frame_tree_node_id_map.Get().insert(
106 std::make_pair(frame_tree_node_id_, this)); 107 std::make_pair(frame_tree_node_id_, this));
107 CHECK(result.second); 108 CHECK(result.second);
109
110 TRACE_EVENT_OBJECT_CREATED_WITH_ID(
111 "navigation", "FrameTreeNode",
112 TRACE_ID_WITH_SCOPE("FrameTreeNode", frame_tree_node_id_));
113 // Don't TraceSnapshot() until the RenderFrameHostManager is initialized and
114 // calls SetCurrentURL().
108 } 115 }
109 116
110 FrameTreeNode::~FrameTreeNode() { 117 FrameTreeNode::~FrameTreeNode() {
111 children_.clear(); 118 children_.clear();
112 frame_tree_->FrameRemoved(this); 119 frame_tree_->FrameRemoved(this);
113 FOR_EACH_OBSERVER(Observer, observers_, OnFrameTreeNodeDestroyed(this)); 120 FOR_EACH_OBSERVER(Observer, observers_, OnFrameTreeNodeDestroyed(this));
114 121
115 if (opener_) 122 if (opener_)
116 opener_->RemoveObserver(opener_observer_.get()); 123 opener_->RemoveObserver(opener_observer_.get());
117 124
118 g_frame_tree_node_id_map.Get().erase(frame_tree_node_id_); 125 g_frame_tree_node_id_map.Get().erase(frame_tree_node_id_);
126
127 TRACE_EVENT_OBJECT_DELETED_WITH_ID(
128 "navigation", "FrameTreeNode",
129 TRACE_ID_WITH_SCOPE("FrameTreeNode", frame_tree_node_id_));
119 } 130 }
120 131
121 void FrameTreeNode::AddObserver(Observer* observer) { 132 void FrameTreeNode::AddObserver(Observer* observer) {
122 observers_.AddObserver(observer); 133 observers_.AddObserver(observer);
123 } 134 }
124 135
125 void FrameTreeNode::RemoveObserver(Observer* observer) { 136 void FrameTreeNode::RemoveObserver(Observer* observer) {
126 observers_.RemoveObserver(observer); 137 observers_.RemoveObserver(observer);
127 } 138 }
128 139
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 scoped_ptr<FrameTreeNode> node_to_delete(std::move(*iter)); 176 scoped_ptr<FrameTreeNode> node_to_delete(std::move(*iter));
166 children_.erase(iter); 177 children_.erase(iter);
167 node_to_delete.reset(); 178 node_to_delete.reset();
168 return; 179 return;
169 } 180 }
170 } 181 }
171 } 182 }
172 183
173 void FrameTreeNode::ResetForNewProcess() { 184 void FrameTreeNode::ResetForNewProcess() {
174 current_frame_host()->set_last_committed_url(GURL()); 185 current_frame_host()->set_last_committed_url(GURL());
186 TraceSnapshot();
175 187
176 // Remove child nodes from the tree, then delete them. This destruction 188 // Remove child nodes from the tree, then delete them. This destruction
177 // operation will notify observers. 189 // operation will notify observers.
178 std::vector<scoped_ptr<FrameTreeNode>>().swap(children_); 190 std::vector<scoped_ptr<FrameTreeNode>>().swap(children_);
179 } 191 }
180 192
181 void FrameTreeNode::SetOpener(FrameTreeNode* opener) { 193 void FrameTreeNode::SetOpener(FrameTreeNode* opener) {
182 if (opener_) { 194 if (opener_) {
183 opener_->RemoveObserver(opener_observer_.get()); 195 opener_->RemoveObserver(opener_observer_.get());
184 opener_observer_.reset(); 196 opener_observer_.reset();
185 } 197 }
186 198
187 opener_ = opener; 199 opener_ = opener;
188 200
189 if (opener_) { 201 if (opener_) {
190 if (!opener_observer_) 202 if (!opener_observer_)
191 opener_observer_ = make_scoped_ptr(new OpenerDestroyedObserver(this)); 203 opener_observer_ = make_scoped_ptr(new OpenerDestroyedObserver(this));
192 opener_->AddObserver(opener_observer_.get()); 204 opener_->AddObserver(opener_observer_.get());
193 } 205 }
194 } 206 }
195 207
196 void FrameTreeNode::SetCurrentURL(const GURL& url) { 208 void FrameTreeNode::SetCurrentURL(const GURL& url) {
197 if (!has_committed_real_load_ && url != GURL(url::kAboutBlankURL)) 209 if (!has_committed_real_load_ && url != GURL(url::kAboutBlankURL))
198 has_committed_real_load_ = true; 210 has_committed_real_load_ = true;
199 current_frame_host()->set_last_committed_url(url); 211 current_frame_host()->set_last_committed_url(url);
212 TraceSnapshot();
200 } 213 }
201 214
202 void FrameTreeNode::SetCurrentOrigin(const url::Origin& origin) { 215 void FrameTreeNode::SetCurrentOrigin(const url::Origin& origin) {
203 if (!origin.IsSameOriginWith(replication_state_.origin)) 216 if (!origin.IsSameOriginWith(replication_state_.origin))
204 render_manager_.OnDidUpdateOrigin(origin); 217 render_manager_.OnDidUpdateOrigin(origin);
205 replication_state_.origin = origin; 218 replication_state_.origin = origin;
206 } 219 }
207 220
208 void FrameTreeNode::SetFrameName(const std::string& name, 221 void FrameTreeNode::SetFrameName(const std::string& name,
209 const std::string& unique_name) { 222 const std::string& unique_name) {
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 if (speculative_frame_host) 454 if (speculative_frame_host)
442 speculative_frame_host->ResetLoadingState(); 455 speculative_frame_host->ResetLoadingState();
443 } else { 456 } else {
444 RenderFrameHostImpl* pending_frame_host = 457 RenderFrameHostImpl* pending_frame_host =
445 render_manager_.pending_frame_host(); 458 render_manager_.pending_frame_host();
446 if (pending_frame_host) 459 if (pending_frame_host)
447 pending_frame_host->ResetLoadingState(); 460 pending_frame_host->ResetLoadingState();
448 } 461 }
449 } 462 }
450 463
464 void FrameTreeNode::TraceSnapshot() const {
465 DCHECK_CURRENTLY_ON(BrowserThread::UI);
466 TRACE_EVENT_OBJECT_SNAPSHOT_WITH_ID(
467 "navigation", "FrameTreeNode",
468 TRACE_ID_WITH_SCOPE("FrameTreeNode", frame_tree_node_id_),
469 scoped_ptr<base::trace_event::ConvertableToTraceFormat>(
470 new TracedFrameTreeNode(*this)));
471 }
472
451 } // namespace content 473 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/frame_host/frame_tree_node.h ('k') | content/browser/frame_host/traced_frame_tree_node.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698