|
Revert of Rework CallApi*Stubs. (patchset #5 id:100001 of https://codereview.chromium.org/1748123003/ )
Reason for revert:
Breaks Chromium.
Original issue's description:
> Rework CallApi*Stubs.
>
> - Eliminate stubs with a variable number of arguments.
> (That only worked due to their very limited use. These
> stubs' interface descriptors were basically lying
> about their number of args, which will fail when used
> generically.)
> - Fix all CallApi*Stubs' interface descriptors to no
> longer lie about their arguments.
> - Unify CallApi*Stub, for * in Function, Accessor,
> FunctionWithFixedArgs.
> (Since these are now all doing the same thing.)
> - Rename the unified stub (and interface descriptors) to
> *ApiCallback*, since that's really what they're doing.
> - Refuse inlining an API callback if its number of
> parameters exceeds the supported number of args.
>
> BUG=
>
> Committed: https://crrev.com/d238b953a474272c0e3ea22ef6a9b63fa9729340
> Cr-Commit-Position: refs/heads/master@{#34614}
TBR=danno@chromium.org,jkummerow@chromium.org,mstarzinger@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Committed: https://crrev.com/52a741d18e77cbd3e57bd8bcce0bfc714eaf6026
Cr-Commit-Position: refs/heads/master@{#34624}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+779 lines, -348 lines) |
Patch |
|
M |
src/arm/code-stubs-arm.cc
|
View
|
|
6 chunks |
+54 lines, -16 lines |
0 comments
|
Download
|
|
M |
src/arm/interface-descriptors-arm.cc
|
View
|
|
2 chunks |
+19 lines, -1 line |
0 comments
|
Download
|
|
M |
src/arm64/code-stubs-arm64.cc
|
View
|
|
5 chunks |
+51 lines, -13 lines |
0 comments
|
Download
|
|
M |
src/arm64/interface-descriptors-arm64.cc
|
View
|
|
2 chunks |
+19 lines, -1 line |
0 comments
|
Download
|
|
M |
src/code-stubs.h
|
View
|
|
3 chunks |
+58 lines, -26 lines |
0 comments
|
Download
|
|
M |
src/compiler/fast-accessor-assembler.cc
|
View
|
|
3 chunks |
+16 lines, -14 lines |
0 comments
|
Download
|
|
M |
src/crankshaft/hydrogen.cc
|
View
|
|
2 chunks |
+17 lines, -10 lines |
0 comments
|
Download
|
|
M |
src/ia32/code-stubs-ia32.cc
|
View
|
|
7 chunks |
+61 lines, -16 lines |
0 comments
|
Download
|
|
M |
src/ia32/interface-descriptors-ia32.cc
|
View
|
|
1 chunk |
+15 lines, -1 line |
0 comments
|
Download
|
|
M |
src/ic/arm/handler-compiler-arm.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/ic/arm64/handler-compiler-arm64.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/ic/ia32/handler-compiler-ia32.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/ic/mips/handler-compiler-mips.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/ic/mips64/handler-compiler-mips64.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/ic/ppc/handler-compiler-ppc.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/ic/s390/handler-compiler-s390.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/ic/x64/handler-compiler-x64.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/ic/x87/handler-compiler-x87.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/interface-descriptors.h
|
View
|
|
7 chunks |
+22 lines, -101 lines |
0 comments
|
Download
|
|
M |
src/interface-descriptors.cc
|
View
|
|
1 chunk |
+18 lines, -35 lines |
0 comments
|
Download
|
|
M |
src/mips/code-stubs-mips.cc
|
View
|
|
5 chunks |
+54 lines, -14 lines |
0 comments
|
Download
|
|
M |
src/mips/interface-descriptors-mips.cc
|
View
|
|
1 chunk |
+15 lines, -1 line |
0 comments
|
Download
|
|
M |
src/mips64/code-stubs-mips64.cc
|
View
|
|
5 chunks |
+58 lines, -17 lines |
0 comments
|
Download
|
|
M |
src/mips64/interface-descriptors-mips64.cc
|
View
|
|
1 chunk |
+15 lines, -1 line |
0 comments
|
Download
|
|
M |
src/ppc/code-stubs-ppc.cc
|
View
|
|
6 chunks |
+51 lines, -15 lines |
0 comments
|
Download
|
|
M |
src/ppc/interface-descriptors-ppc.cc
|
View
|
|
1 chunk |
+15 lines, -1 line |
0 comments
|
Download
|
|
M |
src/s390/code-stubs-s390.cc
|
View
|
|
6 chunks |
+50 lines, -14 lines |
0 comments
|
Download
|
|
M |
src/s390/interface-descriptors-s390.cc
|
View
|
|
1 chunk |
+13 lines, -1 line |
0 comments
|
Download
|
|
M |
src/x64/code-stubs-x64.cc
|
View
|
|
6 chunks |
+51 lines, -14 lines |
0 comments
|
Download
|
|
M |
src/x64/interface-descriptors-x64.cc
|
View
|
|
1 chunk |
+15 lines, -1 line |
0 comments
|
Download
|
|
M |
src/x87/code-stubs-x87.cc
|
View
|
|
7 chunks |
+59 lines, -16 lines |
0 comments
|
Download
|
|
M |
src/x87/interface-descriptors-x87.cc
|
View
|
|
1 chunk |
+15 lines, -1 line |
0 comments
|
Download
|
Total messages: 5 (1 generated)
|