Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1775913002: Flatten strings before internalization (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Flatten strings before internalization BUG=chromium:592707 LOG=n Committed: https://crrev.com/f9398f46723490d8378ad8446eb373152b48e264 Cr-Commit-Position: refs/heads/master@{#34584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/objects.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-08 12:11:14 UTC) #2
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-08 12:42:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775913002/1
4 years, 9 months ago (2016-03-08 12:42:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/16503)
4 years, 9 months ago (2016-03-08 12:48:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775913002/1
4 years, 9 months ago (2016-03-08 13:02:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 13:18:02 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 13:19:34 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f9398f46723490d8378ad8446eb373152b48e264
Cr-Commit-Position: refs/heads/master@{#34584}

Powered by Google App Engine
This is Rietveld 408576698