Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: tests/compiler/dart2js/diagnose_ambiguous_test.dart

Issue 17759007: First pass at asynchronous input loading in dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/diagnose_ambiguous_test.dart
diff --git a/tests/compiler/dart2js/diagnose_ambiguous_test.dart b/tests/compiler/dart2js/diagnose_ambiguous_test.dart
index 70d2fb48aec82512ec8b0562761a727e3edb3d5a..e026f90da910d38301db98126075f0bd5c6a18b6 100644
--- a/tests/compiler/dart2js/diagnose_ambiguous_test.dart
+++ b/tests/compiler/dart2js/diagnose_ambiguous_test.dart
@@ -3,6 +3,7 @@
// BSD-style license that can be found in the LICENSE file.
import 'package:expect/expect.dart';
+import "package:async_helper/async_helper.dart";
import 'memory_source_file_helper.dart';
import '../../../sdk/lib/_internal/compiler/compiler.dart'
@@ -15,8 +16,7 @@ main() {
Uri libraryRoot = script.resolve('../../../sdk/');
Uri packageRoot = script.resolve('./packages/');
- MemorySourceFileProvider.MEMORY_SOURCE_FILES = MEMORY_SOURCE_FILES;
- var provider = new MemorySourceFileProvider();
+ var provider = new MemorySourceFileProvider(MEMORY_SOURCE_FILES);
var diagnostics = [];
void diagnosticHandler(Uri uri, int begin, int end,
String message, Diagnostic kind) {
@@ -32,28 +32,30 @@ main() {
libraryRoot,
packageRoot,
['--analyze-only']);
- compiler.run(Uri.parse('memory:main.dart'));
- diagnostics.sort();
- var expected = [
- 'memory:exporter.dart:43:47:Info: "function(hest)" is defined here.:info',
- 'memory:library.dart:14:19:Info: "class(Fisk)" is (re)exported by '
- 'multiple libraries.:info',
- 'memory:library.dart:30:34:Info: "function(fisk)" is (re)exported by '
- 'multiple libraries.:info',
- 'memory:library.dart:41:45:Info: "function(hest)" is defined here.'
- ':info',
- 'memory:main.dart:0:22:Info: "class(Fisk)" is imported here.:info',
- 'memory:main.dart:0:22:Info: "function(fisk)" is imported here.:info',
- 'memory:main.dart:0:22:Info: "function(hest)" is imported here.:info',
- 'memory:main.dart:23:46:Info: "class(Fisk)" is imported here.:info',
- 'memory:main.dart:23:46:Info: "function(fisk)" is imported here.:info',
- 'memory:main.dart:23:46:Info: "function(hest)" is imported here.:info',
- 'memory:main.dart:59:63:Warning: Duplicate import of "Fisk".:warning',
- 'memory:main.dart:76:80:Error: Duplicate import of "fisk".:error',
- 'memory:main.dart:86:90:Error: Duplicate import of "hest".:error'
- ];
- Expect.listEquals(expected, diagnostics);
- Expect.isTrue(compiler.compilationFailed);
+ asyncTest(() => compiler.run(Uri.parse('memory:main.dart')).then((_) {
+ diagnostics.sort();
+ var expected = [
+ 'memory:exporter.dart:43:47:Info: "function(hest)" is defined here.'
+ ':info',
+ 'memory:library.dart:14:19:Info: "class(Fisk)" is (re)exported by '
+ 'multiple libraries.:info',
+ 'memory:library.dart:30:34:Info: "function(fisk)" is (re)exported by '
+ 'multiple libraries.:info',
+ 'memory:library.dart:41:45:Info: "function(hest)" is defined here.'
+ ':info',
+ 'memory:main.dart:0:22:Info: "class(Fisk)" is imported here.:info',
+ 'memory:main.dart:0:22:Info: "function(fisk)" is imported here.:info',
+ 'memory:main.dart:0:22:Info: "function(hest)" is imported here.:info',
+ 'memory:main.dart:23:46:Info: "class(Fisk)" is imported here.:info',
+ 'memory:main.dart:23:46:Info: "function(fisk)" is imported here.:info',
+ 'memory:main.dart:23:46:Info: "function(hest)" is imported here.:info',
+ 'memory:main.dart:59:63:Warning: Duplicate import of "Fisk".:warning',
+ 'memory:main.dart:76:80:Error: Duplicate import of "fisk".:error',
+ 'memory:main.dart:86:90:Error: Duplicate import of "hest".:error'
+ ];
+ Expect.listEquals(expected, diagnostics);
+ Expect.isTrue(compiler.compilationFailed);
+ }));
}
const Map MEMORY_SOURCE_FILES = const {
« no previous file with comments | « tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart ('k') | tests/compiler/dart2js/emit_const_fields_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698