Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: tests/compiler/dart2js/deprecated_features_test.dart

Issue 17759007: First pass at asynchronous input loading in dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/deprecated_features_test.dart
diff --git a/tests/compiler/dart2js/deprecated_features_test.dart b/tests/compiler/dart2js/deprecated_features_test.dart
index 3d0a12e91c26abdf7126773364d3c6231bf3936d..84764df9ec40cad16e2237a3da1861bf677b0382 100644
--- a/tests/compiler/dart2js/deprecated_features_test.dart
+++ b/tests/compiler/dart2js/deprecated_features_test.dart
@@ -33,38 +33,38 @@ main() {
return new Future<String>.value(source);
}
- String code = deprecatedFutureValue(
- compile(new Uri(scheme: 'main'),
- new Uri(scheme: 'lib', path: '/'),
- new Uri(scheme: 'package', path: '/'),
- provider, handler));
- if (code == null) {
- throw 'Compilation failed: ${messages}';
- }
- Expect.stringEquals(
- // This string is composed of lines of the following format:
- //
- // offset<source>:path:kind: message
- //
- // "offset" is the character offset from the beginning of TEST_SOURCE.
- // "source" is the substring of TEST_SOURCE that the compiler is
- // indicating as erroneous.
- // "path" is the URI path.
- // "kind" is the result of calling toString on a [Diagnostic] object.
- // "message" is the expected message as a [String]. This is a
- // short-term solution and should eventually changed to include
- // a symbolic reference to a MessageKind.
- "0<#library('test');>::${deprecatedMessage('# tags')}\n"
- "19<part 'part.dart';>::${deprecatedMessage('missing part-of tag')}\n"
- "0<>:/part.dart:info: Note: This file has no part-of tag, but it is being"
- " used as a part.\n"
+ compile(new Uri(scheme: 'main'),
+ new Uri(scheme: 'lib', path: '/'),
+ new Uri(scheme: 'package', path: '/'),
+ provider, handler).then((code) {
+ if (code == null) {
+ throw 'Compilation failed: ${messages}';
+ }
+ Expect.stringEquals(
+ // This string is composed of lines of the following format:
+ //
+ // offset<source>:path:kind: message
+ //
+ // "offset" is the character offset from the beginning of TEST_SOURCE.
+ // "source" is the substring of TEST_SOURCE that the compiler is
+ // indicating as erroneous.
+ // "path" is the URI path.
+ // "kind" is the result of calling toString on a [Diagnostic] object.
+ // "message" is the expected message as a [String]. This is a
+ // short-term solution and should eventually changed to include
+ // a symbolic reference to a MessageKind.
+ "0<#library('test');>::${deprecatedMessage('# tags')}\n"
+ "19<part 'part.dart';>::${deprecatedMessage('missing part-of tag')}\n"
+ "0<>:/part.dart:info: Note: This file has no part-of tag, but it is"
+ " being used as a part.\n"
- // TODO(ahe): Should be <bar>.
- "52<Foo>::${deprecatedMessage('conflicting constructor')}\n"
+ // TODO(ahe): Should be <bar>.
+ "52<Foo>::${deprecatedMessage('conflicting constructor')}\n"
- "72<bar>::info: This member conflicts with a constructor.\n"
- "103<()>::${deprecatedMessage('getter parameters')}\n",
- messages.toString());
+ "72<bar>::info: This member conflicts with a constructor.\n"
+ "103<()>::${deprecatedMessage('getter parameters')}\n",
+ messages.toString());
+ });
}
deprecatedMessage(feature) {

Powered by Google App Engine
This is Rietveld 408576698