Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: tests/compiler/dart2js/class_codegen2_test.dart

Issue 17759007: First pass at asynchronous input loading in dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/class_codegen2_test.dart
diff --git a/tests/compiler/dart2js/class_codegen2_test.dart b/tests/compiler/dart2js/class_codegen2_test.dart
index 99e329d8068207bd80fd2503ce1ba45356eec96e..8a14d125c5c2045ba2627ccc0f440b8e6d81d408 100644
--- a/tests/compiler/dart2js/class_codegen2_test.dart
+++ b/tests/compiler/dart2js/class_codegen2_test.dart
@@ -3,6 +3,7 @@
// BSD-style license that can be found in the LICENSE file.
// Test that parameters keep their names in the output.
+import 'dart:async';
import "package:expect/expect.dart";
import 'compiler_helper.dart';
import 'parser_helper.dart';
@@ -87,15 +88,10 @@ main() {
// At some point Dart2js generated bad object literals with dangling commas:
// { a: true, }. Make sure this doesn't happen again.
RegExp danglingComma = new RegExp(r',[ \n]*}');
- String generated = compileAll(TEST_ONE);
- Expect.isFalse(danglingComma.hasMatch(generated));
- generated = compileAll(TEST_TWO);
- Expect.isFalse(danglingComma.hasMatch(generated));
-
- generated = compileAll(TEST_THREE);
- Expect.isFalse(danglingComma.hasMatch(generated));
-
- generated = compileAll(TEST_FOUR);
- Expect.isFalse(danglingComma.hasMatch(generated));
+ Future.forEach([TEST_ONE, TEST_TWO, TEST_THREE, TEST_FOUR], (test) {
+ return compileAll(test).then((generated) {
+ Expect.isFalse(danglingComma.hasMatch(generated));
+ });
+ });
}

Powered by Google App Engine
This is Rietveld 408576698