| OLD | NEW |
| 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file |
| 2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
| 3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
| 4 // Test that parameters keep their names in the output. | 4 // Test that parameters keep their names in the output. |
| 5 | 5 |
| 6 import 'dart:async'; |
| 6 import "package:expect/expect.dart"; | 7 import "package:expect/expect.dart"; |
| 8 import "package:async_helper/async_helper.dart"; |
| 7 import 'compiler_helper.dart'; | 9 import 'compiler_helper.dart'; |
| 8 import 'parser_helper.dart'; | 10 import 'parser_helper.dart'; |
| 9 | 11 |
| 10 const String TEST_ONE = r""" | 12 const String TEST_ONE = r""" |
| 11 class A { foo() => 499; } | 13 class A { foo() => 499; } |
| 12 class B { bar() => 42; } | 14 class B { bar() => 42; } |
| 13 | 15 |
| 14 main() { | 16 main() { |
| 15 new A().foo(); | 17 new A().foo(); |
| 16 new B().bar(); | 18 new B().bar(); |
| (...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 80 | 82 |
| 81 main() { | 83 main() { |
| 82 foo(new A().foo); | 84 foo(new A().foo); |
| 83 } | 85 } |
| 84 """; | 86 """; |
| 85 | 87 |
| 86 main() { | 88 main() { |
| 87 // At some point Dart2js generated bad object literals with dangling commas: | 89 // At some point Dart2js generated bad object literals with dangling commas: |
| 88 // { a: true, }. Make sure this doesn't happen again. | 90 // { a: true, }. Make sure this doesn't happen again. |
| 89 RegExp danglingComma = new RegExp(r',[ \n]*}'); | 91 RegExp danglingComma = new RegExp(r',[ \n]*}'); |
| 90 String generated = compileAll(TEST_ONE); | |
| 91 Expect.isFalse(danglingComma.hasMatch(generated)); | |
| 92 | 92 |
| 93 generated = compileAll(TEST_TWO); | 93 asyncStart(); |
| 94 Expect.isFalse(danglingComma.hasMatch(generated)); | 94 Future.forEach([TEST_ONE, TEST_TWO, TEST_THREE, TEST_FOUR], (test) { |
| 95 | 95 return compileAll(test).then((generated) { |
| 96 generated = compileAll(TEST_THREE); | 96 Expect.isFalse(danglingComma.hasMatch(generated)); |
| 97 Expect.isFalse(danglingComma.hasMatch(generated)); | 97 }); |
| 98 | 98 }).whenComplete(() => asyncEnd()); |
| 99 generated = compileAll(TEST_FOUR); | |
| 100 Expect.isFalse(danglingComma.hasMatch(generated)); | |
| 101 } | 99 } |
| OLD | NEW |