First pass at asynchronous input loading in dart2js.

sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library mirrors_dart2js;
 
 import 'dart:async';
 import 'dart:collection' show LinkedHashMap;
 
 import '../../compiler.dart' as api;
@@ skipping 207 matching lines @@
       compilationFailed = true;
     }
     diagnosticHandler(uri, begin, end, message, kind);
   }
 
   Compiler compiler = new apiimpl.Compiler(inputProvider,
                                            null,
                                            internalDiagnosticHandler,
                                            libraryRoot, packageRoot, options);
   compiler.librariesToAnalyzeWhenRun = libraries;
-  bool success = compiler.run(null);
-  if (success && !compilationFailed) {
-    return new Future<MirrorSystem>.value(new Dart2JsMirrorSystem(compiler));
-  } else {
-    return new Future<MirrorSystem>.error('Failed to create mirror system.');
-  }
+  return compiler.run(null).then((success) {
+    if (success && !compilationFailed) {
+      return new Dart2JsMirrorSystem(compiler);
+    } else {
+      throw 'Failed to create mirror system.';
+    }
+  });

[Bob Nystrom, 2013/06/26 01:03:24]

Well, at least one part of the codebase got cleaner!

[ahe, 2013/06/26 07:02:00]

Indeed!

 }
 
 //------------------------------------------------------------------------------
 // Dart2Js specific extensions of mirror interfaces
 //------------------------------------------------------------------------------
 
 abstract class Dart2JsMirror implements Mirror {
   Dart2JsMirrorSystem get mirrors;
 }
 
@@ skipping 1444 matching lines @@
  *
  * All API in this class is experimental.
  */
 class BackDoor {
   /// Return the compilation units comprising [library].
   static List<Mirror> compilationUnitsOf(Dart2JsLibraryMirror library) {
     return library._library.compilationUnits.toList().map(
         (cu) => new Dart2JsCompilationUnitMirror(cu, library)).toList();
   }
 }