Chromium Code Reviews Chromium Code Reviews
Issue
1775883003:
Revert of Version 5.0.71.10 (cherry-pick) (Closed)
DescriptionRevert of Version 5.0.71.10 (cherry-pick) (patchset #1 id:1 of https://codereview.chromium.org/1777503002/ )
Reason for revert:
This makes "mjsunit/undetectable-compare" fail, some previous drive-by-fix might be missing from the branch that allows us to make the switch away from the CompareIC. This is no longer a quick-fix that can be merged back and we are essentially flying blind on the branch. I am no longer confident that the quick-fix can be merged back. Reverting.
Original issue's description:
> Version 5.0.71.10 (cherry-pick)
>
> Merged 55b4df7357557eb16377ad9227e4e0a4224b7885
> Merged d00da47b61462681b48e48bdff4a80a33da1a6d6
> Merged 4da2e3dbcfc686f68e56c0ad5575257dc2d8ccf1
> Merged c1507e158780b170f25f0f1da87cb5d78a56faee
>
> [runtime] Unify comparison operator runtime entries.
>
> [turbofan] Don't use the CompareIC in JSGenericLowering.
>
> PPC: [runtime] Unify comparison operator runtime entries.
>
> PPC: [turbofan] Don't use the CompareIC in JSGenericLowering.
>
> R=hablich@chromium.org
> BUG=chromium:590832, v8:4788
> LOG=N
>
> Committed: https://chromium.googlesource.com/v8/v8/+/0843a173996f5f63eca749d6fe8c20d4813537d9
TBR=hablich@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:590832, v8:4788
Patch Set 1 #
Messages
Total messages: 3 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
