Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4186)

Unified Diff: build_tools/naclprocess.js

Issue 1775823002: Fix regressions in devenv mounts due to lint change. (Closed) Base URL: https://chromium.googlesource.com/webports.git@master
Patch Set: fix Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build_tools/naclprocess.js
diff --git a/build_tools/naclprocess.js b/build_tools/naclprocess.js
index f8ce45f63146dffd0da162ae6e1161a4b8facefb..f147a03da316420143145443009099aff0cc3c98 100644
--- a/build_tools/naclprocess.js
+++ b/build_tools/naclprocess.js
@@ -486,9 +486,10 @@ NaClProcessManager.prototype.isRootProcess = function (process) {
* a process responds with a mount status update
*/
NaClProcessManager.prototype.broadcastMessage = function (message, callback) {
- this.mountUpdateCallback = callback;
- Object.keys(this.processes).forEach(function (key) {
- this.processes[key].domElement.postMessage(message);
+ var self = this;
+ self.mountUpdateCallback = callback;
+ Object.keys(self.processes).forEach(function (key) {
+ self.processes[key].domElement.postMessage(message);
});
};
@@ -503,22 +504,23 @@ NaClProcessManager.prototype.log = function (msg) {
* is recieved from a process.
*/
NaClProcessManager.prototype.syncMountStatus_ = function () {
+ var self = this;
var result = true;
if (g_mount.available) {
- Object.keys(this.processes).forEach(function (p) {
- result = (result && this.processes[p].mounted);
+ Object.keys(self.processes).forEach(function (p) {
+ result = (result && self.processes[p].mounted);
});
} else {
result = false;
- Object.keys(this.processes).forEach(function (p) {
- result = (result || this.processes[p].mounted);
+ Object.keys(self.processes).forEach(function (p) {
+ result = (result || self.processes[p].mounted);
});
}
g_mount.mounted = result;
- if (this.mountUpdateCallback !== null) {
- this.mountUpdateCallback();
+ if (self.mountUpdateCallback !== null) {
+ self.mountUpdateCallback();
}
return result;
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698