Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1775823002: Fix regressions in devenv mounts due to lint change. (Closed)

Created:
4 years, 9 months ago by bradnelson
Modified:
4 years, 9 months ago
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/webports.git@master
Target Ref:
refs/heads/master
Project:
webports
Visibility:
Public.

Description

Fix regressions in devenv mounts due to lint change. This change: https://codereview.chromium.org/1436283002/ Introduced some bad changes to naclprocess (wrong this). Fixing. BUG=None TEST=None R=gdeepti@chromium.org,petewil@chromium.org Committed: https://chromium.googlesource.com/webports/+/0ab2aa892434aa9929eeb9ece8d0a0703a5eb789

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M build_tools/naclprocess.js View 1 2 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
bradn
4 years, 9 months ago (2016-03-08 07:09:03 UTC) #2
gdeepti1
lgtm
4 years, 9 months ago (2016-03-08 18:59:26 UTC) #4
Pete Williamson
lgtm
4 years, 9 months ago (2016-03-08 21:12:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775823002/20001
4 years, 9 months ago (2016-03-08 21:52:05 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 00:26:17 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/webports/+/0ab2aa892434aa9929eeb9ece8d0a070...

Powered by Google App Engine
This is Rietveld 408576698