Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1775763002: gpu: Ensure that preempted channels wake up after preemption. (Closed)

Created:
4 years, 9 months ago by sunnyps
Modified:
4 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Ensure that preempted channels wake up after preemption. When a message queue is paused it is either due to preemption or being descheduled. If it's because of preemption the message queue should post a task to wake up later. Otherwise it will remain stuck forever and because of sync token dependencies it's possible that the browser also gets stuck. BUG=591192 TEST=manual testing of hw accelerated video and webgl Committed: https://crrev.com/f00f494dfc11b277c0b882735d9e1649d5156bea Cr-Commit-Position: refs/heads/master@{#379895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/common/gpu/gpu_channel.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sunnyps
PTAL
4 years, 9 months ago (2016-03-08 02:51:46 UTC) #2
piman
LGTM. Thanks for debugging this. Not blocking this change, but do you think there's a ...
4 years, 9 months ago (2016-03-08 16:22:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775763002/1
4 years, 9 months ago (2016-03-08 18:28:03 UTC) #5
sunnyps
Thanks for the review. I think we can test the preemption state machine rather easily ...
4 years, 9 months ago (2016-03-08 18:29:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 20:07:46 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 20:08:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f00f494dfc11b277c0b882735d9e1649d5156bea
Cr-Commit-Position: refs/heads/master@{#379895}

Powered by Google App Engine
This is Rietveld 408576698