Issue 1775673002: Fix deprecation message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1775673002: Fix deprecation message (Closed)

Created:
4 years, 9 months ago by vsm

Modified:
4 years, 9 months ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix deprecation message TBR=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/c801bc3058a668c7805670d269675c726b56637e

Patch Set 1 #

Total comments: 1

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+501 lines, -448 lines)			Patch
M	lib/runtime/dart/html.js	View	42 chunks	+95 lines, -95 lines	0 comments	Download
M	lib/runtime/dart/math.js	View	1 chunk	+1 line, -1 line	1 comment	Download
M	lib/src/codegen/js_codegen.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/codegen/expect/js_test.txt	View	1 chunk	+284 lines, -284 lines	0 comments	Download
M	test/codegen/expect/language-all.js	View	Binary file		0 comments	Download
M	tool/sdk_expected_errors.txt	View	10 chunks	+120 lines, -67 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

Committed patchset #1 (id:1) manually as c801bc3058a668c7805670d269675c726b56637e (presubmit successful).

4 years, 9 months ago (2016-03-07 23:33:19 UTC) #2

Jennifer Messerly

4 years, 9 months ago (2016-03-08 00:21:31 UTC) #3

Message was sent while issue was closed.

LGTM. We could also change how we run Analyzer so hints don't cause us to fail?

https://codereview.chromium.org/1775673002/diff/1/lib/runtime/dart/math.js
File lib/runtime/dart/math.js (right):

https://codereview.chromium.org/1775673002/diff/1/lib/runtime/dart/math.js#ne...
lib/runtime/dart/math.js:46: if (!dart.is(other, Point$(core.num))) return
false;
Hmm, so we now convert `other is Point` to `other is Point<num>`. I think that
should be fine, because you can't create a `Point<dynamic>`. But it's a bit
interesting :)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages