Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1775643002: Mark usb/usbDevice.html as a slow LayoutTest. (Closed)

Created:
4 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 9 months ago
Reviewers:
scheib
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark usb/usbDevice.html as a slow LayoutTest. I don't believe this test actually fails on bots. It simply does a bunch of work and needs some extra time to run. Mark it as slow to see if that makes the timeouts go away. If not then there is a real bug in the test. BUG=592183 Committed: https://crrev.com/ee57f6c40d33921df8364e4710a73620b57ccdb5 Cr-Commit-Position: refs/heads/master@{#379707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/SlowTests View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 9 months ago (2016-03-07 22:24:44 UTC) #2
scheib
LGTM
4 years, 9 months ago (2016-03-07 22:26:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775643002/1
4 years, 9 months ago (2016-03-07 22:27:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/34534) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 9 months ago (2016-03-07 22:33:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775643002/1
4 years, 9 months ago (2016-03-08 00:45:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/192694)
4 years, 9 months ago (2016-03-08 01:28:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775643002/1
4 years, 9 months ago (2016-03-08 01:49:48 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 02:53:50 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 02:55:20 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee57f6c40d33921df8364e4710a73620b57ccdb5
Cr-Commit-Position: refs/heads/master@{#379707}

Powered by Google App Engine
This is Rietveld 408576698