Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1775593002: Update status files: websql_test seems to pass in ie10, many failures seem to be (Closed)

Created:
4 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 9 months ago
Reviewers:
Alan Knight, terry
CC:
reviews_dartlang.org, terry
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status files: websql_test seems to pass in ie10, many failures seem to be timeouts in windows, a couple new runtime-error failures in safari. BUG= Committed: https://github.com/dart-lang/sdk/commit/43f943245e09302b31ff1f995f17d37336f43b63

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M tests/co19/co19-dart2js.status View 5 chunks +11 lines, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_api_test.dart View 1 1 chunk +10 lines, -0 lines 1 comment Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Siggi Cherem (dart-lang)
4 years, 9 months ago (2016-03-07 20:33:45 UTC) #2
Siggi Cherem (dart-lang)
also added back the whitelist for errors that we still have in analyze_api_test.
4 years, 9 months ago (2016-03-07 20:40:28 UTC) #3
Siggi Cherem (dart-lang)
Committed patchset #2 (id:20001) manually as 43f943245e09302b31ff1f995f17d37336f43b63 (presubmit successful).
4 years, 9 months ago (2016-03-07 20:41:19 UTC) #5
terry
4 years, 9 months ago (2016-03-07 21:48:59 UTC) #7
Message was sent while issue was closed.
lgtm thanks

https://codereview.chromium.org/1775593002/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/analyze_api_test.dart (right):

https://codereview.chromium.org/1775593002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/analyze_api_test.dart:31: ]
Thanks Siggi, I'm working on the remaining there are more UIEvent changes in
roll 45.

Powered by Google App Engine
This is Rietveld 408576698