Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1775563004: Move ModuleInitializer::init out of initializeWithoutV8 (Closed)

Created:
4 years, 9 months ago by haraken
Modified:
4 years, 9 months ago
Reviewers:
kinuko, sof, yhirano
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ModuleInitializer::init out of initializeWithoutV8 It looks like that the call sites of initializeWithoutV8 doesn't need to initialize the HTML parser thread. We can factor out ModuleInitializer.init() from initializeWithoutV8 to initialize. With this CL, we can get rid of the dependency from initializeWithoutV8 to core/ and modules/. I'll move initializeWithoutV8/shutdownWithoutV8 from web/ to platform/ in the next CL. BUG= Committed: https://crrev.com/728a85b9f9fc4e640cf4829a760a0cbc6373147e Cr-Commit-Position: refs/heads/master@{#379785}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/Source/web/WebKit.cpp View 1 4 chunks +12 lines, -12 lines 1 comment Download

Messages

Total messages: 15 (6 generated)
haraken
PTAL Sorry, I was wrong -- it looks like the call sites of initializeWithoutV8 doesn't ...
4 years, 9 months ago (2016-03-08 04:48:40 UTC) #3
haraken
4 years, 9 months ago (2016-03-08 04:48:52 UTC) #5
sof
lgtm (but no web/ owner) I guess that raises the question if detachMainThread() can move ...
4 years, 9 months ago (2016-03-08 06:31:27 UTC) #6
haraken
> I guess that raises the question if detachMainThread() can move out also. Maybe or ...
4 years, 9 months ago (2016-03-08 06:36:11 UTC) #7
yhirano
lgtm https://codereview.chromium.org/1775563004/diff/20001/third_party/WebKit/Source/web/WebKit.cpp File third_party/WebKit/Source/web/WebKit.cpp (right): https://codereview.chromium.org/1775563004/diff/20001/third_party/WebKit/Source/web/WebKit.cpp#newcode107 third_party/WebKit/Source/web/WebKit.cpp:107: setIndexedDBClientCreateFunction(IndexedDBClientImpl::create); [optional] Can we move this function call ...
4 years, 9 months ago (2016-03-08 07:05:24 UTC) #8
haraken
> https://codereview.chromium.org/1775563004/diff/20001/third_party/WebKit/Source/web/WebKit.cpp > File third_party/WebKit/Source/web/WebKit.cpp (right): > > https://codereview.chromium.org/1775563004/diff/20001/third_party/WebKit/Source/web/WebKit.cpp#newcode107 > third_party/WebKit/Source/web/WebKit.cpp:107: > setIndexedDBClientCreateFunction(IndexedDBClientImpl::create); > [optional] ...
4 years, 9 months ago (2016-03-08 07:17:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1775563004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1775563004/20001
4 years, 9 months ago (2016-03-08 07:17:57 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 08:22:22 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 08:23:47 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/728a85b9f9fc4e640cf4829a760a0cbc6373147e
Cr-Commit-Position: refs/heads/master@{#379785}

Powered by Google App Engine
This is Rietveld 408576698