Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 177553005: Updates to WebRTC Baremetal recipe (Closed)

Created:
6 years, 10 months ago by kjellander_chromium
Modified:
6 years, 9 months ago
Reviewers:
iannucci
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Visibility:
Public.

Description

Updates to WebRTC Baremetal recipe * Add webrtc_perf_tests to all platforms. * Remove libjingle_peerconnection_objc_test as it's only supposed to run for x64 builds on Mac, and don't depend on baremetal machines. * Reduce the code duplication in the webrtc recipe module. * Add the webrtc-limited solution to the gclient spec since it's needed for Windows. * Remove unused recipe modules. BUG=346198 TEST=On a machine of each platform: scripts/tools/run_recipe.py webrtc/baremetal build_config=Release buildername="Linux64 Release" mastername=client.webrtc slavename=mymachine scripts/tools/run_recipe.py webrtc/baremetal build_config=Release buildername="Mac32 Release" mastername=client.webrtc slavename=mymachine scripts/tools/run_recipe.py webrtc/baremetal build_config=Release buildername="Win32 Release" mastername=client.webrtc slavename=mymachine Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=257089

Patch Set 1 : #

Patch Set 2 : Added webrtc-limited solution for standalone build. #

Total comments: 2

Patch Set 3 : Removed unused recipe modules #

Patch Set 4 : Simplified JSON expectations #

Total comments: 2

Patch Set 5 : Use Chromium's SVN mirror for WebRTC when run in Chrome infra. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -3680 lines) Patch
M scripts/slave/recipe_modules/webrtc/api.py View 1 2 3 4 2 chunks +12 lines, -28 lines 0 comments Download
M scripts/slave/recipe_modules/webrtc/gclient_config.py View 1 2 3 4 4 chunks +26 lines, -15 lines 0 comments Download
M scripts/slave/recipes/webrtc/android_apk.expected/buildbot_Debug_arm.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/android_apk.expected/buildbot_Debug_intel.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/android_apk.expected/buildbot_Release_arm.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/android_apk.expected/buildbot_Release_intel.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/android_apk.expected/trybot_Debug_arm.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/android_apk.expected/trybot_Debug_intel.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/android_apk.expected/trybot_Release_arm.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/android_apk.expected/trybot_Release_intel.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/baremetal.py View 1 2 3 3 chunks +26 lines, -28 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/buildbot_linux32_Debug.json View 1 2 3 4 1 chunk +0 lines, -209 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/buildbot_linux32_Release.json View 1 2 3 4 1 chunk +0 lines, -209 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/buildbot_linux64_Debug.json View 1 2 3 4 1 chunk +0 lines, -209 lines 0 comments Download
M scripts/slave/recipes/webrtc/baremetal.expected/buildbot_linux64_Release.json View 1 2 3 4 9 chunks +52 lines, -27 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/buildbot_mac32_Debug.json View 1 2 3 4 1 chunk +0 lines, -173 lines 0 comments Download
M scripts/slave/recipes/webrtc/baremetal.expected/buildbot_mac32_Release.json View 1 2 3 4 7 chunks +33 lines, -33 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/buildbot_mac64_Debug.json View 1 2 3 4 1 chunk +0 lines, -173 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/buildbot_mac64_Release.json View 1 2 3 4 1 chunk +0 lines, -173 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/buildbot_win32_Debug.json View 1 2 3 4 1 chunk +0 lines, -153 lines 0 comments Download
M scripts/slave/recipes/webrtc/baremetal.expected/buildbot_win32_Release.json View 1 2 3 4 6 chunks +44 lines, -23 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/buildbot_win64_Debug.json View 1 2 3 4 1 chunk +0 lines, -153 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/buildbot_win64_Release.json View 1 2 3 4 1 chunk +0 lines, -153 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/trybot_linux32_Debug.json View 1 2 3 4 1 chunk +0 lines, -234 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/trybot_linux32_Release.json View 1 2 3 4 1 chunk +0 lines, -234 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/trybot_linux64_Debug.json View 1 2 3 4 1 chunk +0 lines, -234 lines 0 comments Download
M scripts/slave/recipes/webrtc/baremetal.expected/trybot_linux64_Release.json View 1 2 3 4 9 chunks +52 lines, -27 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/trybot_mac32_Debug.json View 1 2 3 4 1 chunk +0 lines, -198 lines 0 comments Download
M scripts/slave/recipes/webrtc/baremetal.expected/trybot_mac32_Release.json View 1 2 3 4 7 chunks +33 lines, -33 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/trybot_mac64_Debug.json View 1 2 3 4 1 chunk +0 lines, -198 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/trybot_mac64_Release.json View 1 2 3 4 1 chunk +0 lines, -198 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/trybot_win32_Debug.json View 1 2 3 4 1 chunk +0 lines, -178 lines 0 comments Download
M scripts/slave/recipes/webrtc/baremetal.expected/trybot_win32_Release.json View 1 2 3 4 6 chunks +44 lines, -23 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/trybot_win64_Debug.json View 1 2 3 4 1 chunk +0 lines, -178 lines 0 comments Download
D scripts/slave/recipes/webrtc/baremetal.expected/trybot_win64_Release.json View 1 2 3 4 1 chunk +0 lines, -178 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kjellander_chromium
When doing more testing on Mac and Windows I discovered more things needed to be ...
6 years, 10 months ago (2014-02-25 14:31:12 UTC) #1
iannucci
lgtm, though if we're mirroring the repo, we should use the mirror `if c.USE_MIRROR`. https://chromiumcodereview.appspot.com/177553005/diff/100001/scripts/slave/recipe_modules/webrtc/gclient_config.py ...
6 years, 9 months ago (2014-03-05 23:34:16 UTC) #2
kjellander_chromium
Changed to use the mirror now and it seems to work fine. I suspect you ...
6 years, 9 months ago (2014-03-14 12:46:24 UTC) #3
kjellander_chromium
The CQ bit was checked by kjellander@chromium.org
6 years, 9 months ago (2014-03-14 12:46:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/177553005/120001
6 years, 9 months ago (2014-03-14 12:46:40 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-14 12:47:59 UTC) #6
Message was sent while issue was closed.
Change committed as 257089

Powered by Google App Engine
This is Rietveld 408576698